mirror of
https://github.com/whoisclebs/lodash.git
synced 2026-02-01 23:57:49 +00:00
Make _.max and _.min return unwrapped values when chaining.
This commit is contained in:
@@ -8677,10 +8677,8 @@
|
||||
lodash.map = map;
|
||||
lodash.mapValues = mapValues;
|
||||
lodash.matches = matches;
|
||||
lodash.max = max;
|
||||
lodash.memoize = memoize;
|
||||
lodash.merge = merge;
|
||||
lodash.min = min;
|
||||
lodash.mixin = mixin;
|
||||
lodash.negate = negate;
|
||||
lodash.omit = omit;
|
||||
@@ -8775,6 +8773,8 @@
|
||||
lodash.isUndefined = isUndefined;
|
||||
lodash.kebabCase = kebabCase;
|
||||
lodash.lastIndexOf = lastIndexOf;
|
||||
lodash.max = max;
|
||||
lodash.min = min;
|
||||
lodash.noConflict = noConflict;
|
||||
lodash.noop = noop;
|
||||
lodash.now = now;
|
||||
|
||||
31
test/test.js
31
test/test.js
@@ -3201,11 +3201,6 @@
|
||||
'some'
|
||||
];
|
||||
|
||||
var boolMethods = [
|
||||
'every',
|
||||
'some'
|
||||
];
|
||||
|
||||
var collectionMethods = [
|
||||
'countBy',
|
||||
'every',
|
||||
@@ -3253,6 +3248,13 @@
|
||||
'forOwnRight'
|
||||
];
|
||||
|
||||
var unwrappedMethods = [
|
||||
'every',
|
||||
'max',
|
||||
'min',
|
||||
'some'
|
||||
];
|
||||
|
||||
_.each(methods, function(methodName) {
|
||||
var array = [1, 2, 3],
|
||||
func = _[methodName];
|
||||
@@ -3289,7 +3291,7 @@
|
||||
});
|
||||
});
|
||||
|
||||
_.each(_.difference(methods, boolMethods), function(methodName) {
|
||||
_.each(_.difference(methods, unwrappedMethods), function(methodName) {
|
||||
var array = [1, 2, 3],
|
||||
func = _[methodName];
|
||||
|
||||
@@ -3304,6 +3306,21 @@
|
||||
});
|
||||
});
|
||||
|
||||
_.each(unwrappedMethods, function(methodName) {
|
||||
var array = [1, 2, 3],
|
||||
func = _[methodName];
|
||||
|
||||
test('`_.' + methodName + '` should return an unwrapped value when chaining', 1, function() {
|
||||
if (!isNpm) {
|
||||
var actual = _(array)[methodName](_.noop);
|
||||
ok(!(actual instanceof _));
|
||||
}
|
||||
else {
|
||||
skipTest();
|
||||
}
|
||||
});
|
||||
});
|
||||
|
||||
_.each(_.difference(methods, forInMethods), function(methodName) {
|
||||
var array = [1, 2, 3],
|
||||
func = _[methodName];
|
||||
@@ -6620,7 +6637,7 @@
|
||||
|
||||
test('`_.' + methodName + '` should work when chaining on an array with only one value', 1, function() {
|
||||
if (!isNpm) {
|
||||
var actual = _([40])[methodName]().value();
|
||||
var actual = _([40])[methodName]();
|
||||
strictEqual(actual, 40);
|
||||
}
|
||||
else {
|
||||
|
||||
Reference in New Issue
Block a user