Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-01-29 14:37:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Coerce drop and dropRight n param using toInteger (#4412)

Browse Source 
* Coerce dropRight n param using toInteger

* Coerce drop n param using toInteger
This commit is contained in:
Luiz Américo
2019-08-16 19:52:06 -03:00
committed by John-David Dalton
parent a965836cf3
commit 37cd5dc97a
4 changed files with 5 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drop.js
View File

@@ -1,4 +1,5 @@
import slice from './slice.js'
import toInteger from './toInteger.js'
/**
* Creates a slice of `array` with `n` elements dropped from the beginning.
@@ -25,7 +26,7 @@ import slice from './slice.js'
function drop(array, n=1) {
const length = array == null ? 0 : array.length
return length
? slice(array, n < 0 ? 0 : n, length)
? slice(array, n < 0 ? 0 : toInteger(n), length)
: []
}

4
dropRight.js
View File

@@ -1,4 +1,5 @@
import slice from './slice.js'
import toInteger from './toInteger.js'
/**
* Creates a slice of `array` with `n` elements dropped from the end.
@@ -24,7 +25,8 @@ import slice from './slice.js'
*/
function dropRight(array, n=1) {
const length = array == null ? 0 : array.length
return length ? slice(array, 0, n < 0 ? 0 : -n) : []
n = length - toInteger(n)
return length ? slice(array, 0, n < 0 ? 0 : n) : []
}
export default dropRight

7
test/drop.js → test/drop.test.js
View File

@@ -38,13 +38,6 @@ describe('drop', function() {
assert.deepStrictEqual(drop(array, 1.6), [2, 3]);
});
it('should work as an iteratee for methods like `_.map`', function() {
var array = [[1, 2, 3], [4, 5, 6], [7, 8, 9]],
actual = lodashStable.map(array, drop);
assert.deepStrictEqual(actual, [[2, 3], [5, 6], [8, 9]]);
});
it('should work in a lazy sequence', function() {
var array = lodashStable.range(1, LARGE_ARRAY_SIZE + 1),
predicate = function(value) { values.push(value); return isEven(value); },

7
test/dropRight.js → test/dropRight.test.js
View File

@@ -38,13 +38,6 @@ describe('dropRight', function() {
assert.deepStrictEqual(dropRight(array, 1.6), [1, 2]);
});
it('should work as an iteratee for methods like `_.map`', function() {
var array = [[1, 2, 3], [4, 5, 6], [7, 8, 9]],
actual = lodashStable.map(array, dropRight);
assert.deepStrictEqual(actual, [[1, 2], [4, 5], [7, 8]]);
});
it('should work in a lazy sequence', function() {
var array = lodashStable.range(1, LARGE_ARRAY_SIZE + 1),
predicate = function(value) { values.push(value); return isEven(value); },