Files
lodash/CONTRIBUTING.md
John-David Dalton 4e7b71db1d Cleanup CONTRIBUTING.md and README.md.
Former-commit-id: f0dca3ffc6a23128a877ae4d7d7f409d2e6adb69
2012-12-09 22:36:19 -08:00

2.3 KiB

Contributing to Lo-Dash

If youÕd like to contribute a feature or bug fix, you can fork Lo-Dash, commit your changes, and send a pull request. Please make sure to search the issue tracker first; your issue may have already been discussed or fixed in master.

Tests

Please make sure to update the unit tests in the test directory as part of your pull request. You can run the tests from the command line via npm test, or open test/index.html in a web browser. The test/run-test.sh script attempts to run the tests in Rhino, RingoJS, Narwhal, and Node, before starting your default browser. The Backbone and Underscore test suites are included as well.

We also use Travis CI for continuous integration.

Contributor License Agreement

Lo-Dash is a Dojo Foundation project. As such, we request that all contributors sign the Dojo Foundation contributor license agreement. You can also check if youÕve already signed a CLA.

For more information about CLAs, please check out Alex RussellÕs excellent post, "Why Do I Need to Sign This?".

Coding Guidelines

In addition to the following guidelines, please follow the conventions already established in the code.

  • Spacing: Use two spaces for indentation. No tabs.
  • Naming: Keep variable and method names concise and descriptive. Variable names index, collection, and callback are preferable to i, arr, and fn.
  • Quotes: Single-quoted strings are preferred to double-quoted strings; however, please use a double-quoted string if the value contains a single-quote character to avoid unnecessary escaping.
  • Comments: Please use single-line comments to annotate significant additions, and JSDoc-style comments for new methods. We use Docdown to generate our documentation.