Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-08 02:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add _.isFunction test for NodeList instances.

Browse Source
This commit is contained in:
Graeme Yeates
2015-07-12 19:12:13 -04:00
committed by John-David Dalton
parent 211a6cc4f1
commit ffd3e17364
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lodash.src.js
View File

@@ -8187,8 +8187,9 @@
*/ */
function isFunction(value) { function isFunction(value) {
// The use of `Object#toString` avoids issues with the `typeof` operator // The use of `Object#toString` avoids issues with the `typeof` operator
// in older versions of Chrome and Safari which return 'function' for regexes // in older versions of Chrome and Safari which return 'function' for regexes,
// and Safari 8 which returns 'object' for typed array constructors. // Safari 8 which returns 'object' for typed array constructors, and PhantomJS 1.9
// which returns 'function' for `NodeList` instances.
return isObject(value) && objToString.call(value) == funcTag; return isObject(value) && objToString.call(value) == funcTag;
} }

8
test/test.js
View File

@@ -7338,7 +7338,7 @@
deepEqual(actual, expected); deepEqual(actual, expected);
}); });
test('should return `false` for non-functions', 11, function() { test('should return `false` for non-functions', 12, function() {
var expected = _.map(falsey, _.constant(false)); var expected = _.map(falsey, _.constant(false));
var actual = _.map(falsey, function(value, index) { var actual = _.map(falsey, function(value, index) {
@@ -7357,6 +7357,12 @@
strictEqual(_.isFunction(NaN), false); strictEqual(_.isFunction(NaN), false);
strictEqual(_.isFunction(/x/), false); strictEqual(_.isFunction(/x/), false);
strictEqual(_.isFunction('a'), false); strictEqual(_.isFunction('a'), false);
if (document) {
strictEqual(_.isFunction(document.getElementsByTagName('body')), false);
} else {
skipTest();
}
}); });
test('should work with host objects in IE 8 document mode (test in IE 11)', 2, function() { test('should work with host objects in IE 8 document mode (test in IE 11)', 2, function() {