Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-01 15:57:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extend baseCreateCallback to functions bound with native Function#bind and those with __bindData__ of false.

Browse Source
This commit is contained in:
John-David Dalton
2013-10-04 21:24:10 -07:00
parent e114c18031
commit fd2ddca6f2
8 changed files with 131 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
test/test.js
View File

@@ -625,7 +625,7 @@
strictEqual(_.isEqual(object, clone), true);
if (_.isObject(object)) {
notEqual(clone, object);
notStrictEqual(clone, object);
} else {
strictEqual(clone, object);
}
@@ -640,7 +640,7 @@
test('`_.' + methodName + '` should clone problem JScript properties (test in IE < 9)', 2, function() {
deepEqual(func(shadowedObject), shadowedObject);
notEqual(func(shadowedObject), shadowedObject);
notStrictEqual(func(shadowedObject), shadowedObject);
});
test('`_.' + methodName + '` should pass the correct `callback` arguments', 1, function() {
@@ -809,6 +809,47 @@
callback.apply(null, expected);
deepEqual(args, expected);
});
test('should return the passed function if already bound with `Function#bind`', 1, function() {
function a() {}
if (Function.prototype.bind) {
var bound = a.bind();
strictEqual(_.createCallback(bound, {}), bound);
}
else {
skipTest();
}
});
test('should return the passed function when there is no `this` reference', 2, function() {
function a() {}
function b() { return this.b; }
if (_.support.funcDecomp) {
strictEqual(_.createCallback(a, {}), a);
notStrictEqual(_.createCallback(b, {}), b);
}
else {
skipTest(2);
}
});
test('should only write `__bindData__` to named functions', 2, function() {
function a() {};
var b = function() {};
if (_.support.funcNames || _.support.funcDecomp) {
_.createCallback(a, {});
ok('__bindData__' in a)
_.createCallback(b, {});
ok(!('__bindData__' in b));
}
else {
skipTest(2);
}
});
}());
/*--------------------------------------------------------------------------*/
@@ -4272,7 +4313,7 @@
result[key] = this[key];
}, null, object);
notEqual(actual, object);
notStrictEqual(actual, object);
deepEqual(actual, object);
});
});