Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-10 02:47:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup _.isNil doc examples and tests.

Browse Source
This commit is contained in:
John-David Dalton
2015-08-20 08:03:11 -07:00
parent 7aef780b14
commit f9f7af2430
2 changed files with 23 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lodash.js
View File

@@ -8286,17 +8286,11 @@
* _.isNil(null); * _.isNil(null);
* // => true * // => true
* *
* _.isNil(); * _.isNil(void 0);
* // => true
*
* _.isNil(undefined);
* // => true * // => true
* *
* _.isNil(NaN); * _.isNil(NaN);
* // => false * // => false
*
* _.isNil(void 0);
* // => false
*/ */
function isNil(value) { function isNil(value) {
return value == null; return value == null;

47
test/test.js
View File

@@ -7684,11 +7684,11 @@
(function() { (function() {
var args = arguments; var args = arguments;
test('should return `true` for nulls', 1, function() { test('should return `true` for `null` values', 1, function() {
strictEqual(_.isNull(null), true); strictEqual(_.isNull(null), true);
}); });
test('should return `false` for non-nulls', 13, function() { test('should return `false` for non `null` values', 13, function() {
var expected = _.map(falsey, function(value) { return value === null; }); var expected = _.map(falsey, function(value) { return value === null; });
var actual = _.map(falsey, function(value, index) { var actual = _.map(falsey, function(value, index) {
@@ -7728,38 +7728,35 @@
(function() { (function() {
var args = arguments; var args = arguments;
test('should return `true` for nulls', 1, function() { test('should return `true` for nullish values', 3, function() {
strictEqual(_.isNil(null), true); strictEqual(_.isNil(null), true);
});
test('should return `true` for undefinitions', 2, function() {
strictEqual(_.isNil(), true); strictEqual(_.isNil(), true);
strictEqual(_.isNil(undefined), true); strictEqual(_.isNil(undefined), true);
}); });
test('should return `false` for non-nils', 13, function() { test('should return `false` for non-nullish values', 13, function() {
var expected = _.map(falsey, function(value) { var expected = _.map(falsey, function(value) {
return undefined === value || null === value; return value == null;
}); });
var actual = _.map(falsey, function(value) { var actual = _.map(falsey, function(value, index) {
return _.isNil(value); return index ? _.isNil(value) : _.isNil();
}); });
deepEqual(actual, expected); deepEqual(actual, expected);
strictEqual(_.isNull(args), false); strictEqual(_.isNil(args), false);
strictEqual(_.isNull([1, 2, 3]), false); strictEqual(_.isNil([1, 2, 3]), false);
strictEqual(_.isNull(true), false); strictEqual(_.isNil(true), false);
strictEqual(_.isNull(new Date), false); strictEqual(_.isNil(new Date), false);
strictEqual(_.isNull(new Error), false); strictEqual(_.isNil(new Error), false);
strictEqual(_.isNull(_), false); strictEqual(_.isNil(_), false);
strictEqual(_.isNull(slice), false); strictEqual(_.isNil(slice), false);
strictEqual(_.isNull({ 'a': 1 }), false); strictEqual(_.isNil({ 'a': 1 }), false);
strictEqual(_.isNull(1), false); strictEqual(_.isNil(1), false);
strictEqual(_.isNull(NaN), false); strictEqual(_.isNil(NaN), false);
strictEqual(_.isNull(/x/), false); strictEqual(_.isNil(/x/), false);
strictEqual(_.isNull('a'), false); strictEqual(_.isNil('a'), false);
}); });
test('should work with nulls from another realm', 2, function() { test('should work with nulls from another realm', 2, function() {
@@ -8202,11 +8199,11 @@
}); });
}); });
test('should not error on host objects (test in IE)', 15, function() { test('should not error on host objects (test in IE)', 16, function() {
var funcs = [ var funcs = [
'isArguments', 'isArray', 'isBoolean', 'isDate', 'isElement', 'isArguments', 'isArray', 'isBoolean', 'isDate', 'isElement',
'isError', 'isFinite', 'isFunction', 'isNaN', 'isNull', 'isNumber', 'isError', 'isFinite', 'isFunction', 'isNaN', 'isNil', 'isNull',
'isObject', 'isRegExp', 'isString', 'isUndefined' 'isNumber', 'isObject', 'isRegExp', 'isString', 'isUndefined'
]; ];
_.each(funcs, function(methodName) { _.each(funcs, function(methodName) {