Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-01-29 06:27:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only retry a test if it errors not because of unit test fails.

Browse Source
This commit is contained in:
John-David Dalton
2014-05-16 04:02:40 -07:00
parent 36d2ff7c3b
commit f85543c7ff
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/saucelabs.js
View File

@@ -394,9 +394,11 @@ function onJobStatus(error, res, body) {
jobStatus = _.result(data, 'status', ''), jobStatus = _.result(data, 'status', ''),
jobUrl = _.result(data, 'url', null), jobUrl = _.result(data, 'url', null),
options = this.options, options = this.options,
message = _.result(jobResult, 'message'),
platform = options.platforms[0], platform = options.platforms[0],
description = browserName(platform[1]) + ' ' + platform[2] + ' on ' + capitalizeWords(platform[0]), description = browserName(platform[1]) + ' ' + platform[2] + ' on ' + capitalizeWords(platform[0]),
elapsed = (_.now() - this.timestamp) / 1000, elapsed = (_.now() - this.timestamp) / 1000,
errored = !jobResult || reError.test(message),
expired = (elapsed >= queueTimeout && !_.contains(jobStatus, 'in progress')), expired = (elapsed >= queueTimeout && !_.contains(jobStatus, 'in progress')),
failures = _.result(jobResult, 'failed'), failures = _.result(jobResult, 'failed'),
label = options.name + ':', label = options.name + ':',
@@ -415,8 +417,8 @@ function onJobStatus(error, res, body) {
this._pollerId = _.delay(_.bind(this.status, this), this.statusInterval * 1000); this._pollerId = _.delay(_.bind(this.status, this), this.statusInterval * 1000);
return; return;
} }
if (!jobResult || failures || reError.test(jobResult.message)) { if (errored || failures) {
if (this.attempts < this.retries) { if (errored && this.attempts < this.retries) {
this.restart(); this.restart();
return; return;
} }
@@ -432,7 +434,9 @@ function onJobStatus(error, res, body) {
return; return;
} }
else { else {
var message = _.result(jobResult, 'message', 'no results available. ' + details); if (typeof message == 'undefined') {
message = 'no results available. ' + details;
}
console.error(label, description, chalk.red('failed') + ';', message); console.error(label, description, chalk.red('failed') + ';', message);
} }
} }