Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-11 03:17:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use built-in String#trim methods when possible.

Browse Source
This commit is contained in:
John-David Dalton
2017-02-03 22:49:18 -08:00
parent 9d445ec238
commit f3a8e55e70
3 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
trim.js
View File

@@ -5,8 +5,7 @@ import charsStartIndex from './.internal/charsStartIndex.js';
import stringToArray from './.internal/stringToArray.js'; import stringToArray from './.internal/stringToArray.js';
import toString from './toString.js'; import toString from './toString.js';
/** Used to match leading and trailing whitespace. */ const nativeTrim = String.prototype.trim;
const reTrim = /^\s+|\s+$/g;
/** /**
* Removes leading and trailing whitespace or specified characters from `string`. * Removes leading and trailing whitespace or specified characters from `string`.
@@ -32,7 +31,7 @@ const reTrim = /^\s+|\s+$/g;
function trim(string, chars, guard) { function trim(string, chars, guard) {
string = toString(string); string = toString(string);
if (string && (guard || chars === undefined)) { if (string && (guard || chars === undefined)) {
return string.replace(reTrim, ''); return nativeTrim.call(string);
} }
if (!string || !(chars = baseToString(chars))) { if (!string || !(chars = baseToString(chars))) {
return string; return string;

7
trimEnd.js
View File

@@ -4,8 +4,9 @@ import charsEndIndex from './.internal/charsEndIndex.js';
import stringToArray from './.internal/stringToArray.js'; import stringToArray from './.internal/stringToArray.js';
import toString from './toString.js'; import toString from './toString.js';
/** Used to match leading and trailing whitespace. */ const stringProto = String.prototype;
const reTrimEnd = /\s+$/; const nativeTrimEnd = stringProto.trimRight || stringProto.trimEnd;
/** /**
* Removes trailing whitespace or specified characters from `string`. * Removes trailing whitespace or specified characters from `string`.
@@ -28,7 +29,7 @@ const reTrimEnd = /\s+$/;
function trimEnd(string, chars, guard) { function trimEnd(string, chars, guard) {
string = toString(string); string = toString(string);
if (string && (guard || chars === undefined)) { if (string && (guard || chars === undefined)) {
return string.replace(reTrimEnd, ''); return nativeTrimEnd.call(string);
} }
if (!string || !(chars = baseToString(chars))) { if (!string || !(chars = baseToString(chars))) {
return string; return string;

6
trimStart.js
View File

@@ -4,8 +4,8 @@ import charsStartIndex from './.internal/charsStartIndex.js';
import stringToArray from './.internal/stringToArray.js'; import stringToArray from './.internal/stringToArray.js';
import toString from './toString.js'; import toString from './toString.js';
/** Used to match leading and trailing whitespace. */ const stringProto = String.prototype;
const reTrimStart = /^\s+/; const nativeTrimStart = stringProto.trimLeft || stringProto.trimStart;
/** /**
* Removes leading whitespace or specified characters from `string`. * Removes leading whitespace or specified characters from `string`.
@@ -28,7 +28,7 @@ const reTrimStart = /^\s+/;
function trimStart(string, chars, guard) { function trimStart(string, chars, guard) {
string = toString(string); string = toString(string);
if (string && (guard || chars === undefined)) { if (string && (guard || chars === undefined)) {
return string.replace(reTrimStart, ''); return nativeTrimStart.call(string);
} }
if (!string || !(chars = baseToString(chars))) { if (!string || !(chars = baseToString(chars))) {
return string; return string;