Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-03 16:47:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

lodash: Add the JScript [[DontEnum]] and Firefox, Opera, and Safari "prototype" property iteration fixes to iterationFactory. [jddalton]

Browse Source 
Former-commit-id: f5be5c1e0828c3850936ba13ce19d0bfb8988d05
This commit is contained in:
John-David Dalton
2012-05-06 22:16:03 -04:00
parent 52cf17b24a
commit f31c2d24f9
5 changed files with 231 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
test/test.js
View File

@@ -26,6 +26,17 @@
/** Used to resolve a value's internal [[Class]] */
var toString = {}.toString;
/** Used to check problem JScript properties (a.k.a. the [[DontEnum]] bug) */
var shadowed = {
'constructor': 1,
'hasOwnProperty': 2,
'isPrototypeOf': 3,
'propertyIsEnumerable': 4,
'toLocaleString': 5,
'toString': 6,
'valueOf': 7
};
/*--------------------------------------------------------------------------*/
/**
@@ -130,6 +141,26 @@
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.extend');
(function() {
test('skips the prototype property of functions (test in Firefox < 3.6, Opera > 9.50 - Opera < 11.60, and Safari < 5.1)', function() {
var expected = { 'a': 1, 'b': 2 },
func = function() { };
func.prototype.c = 3;
func.a = 1;
func.b = 2;
deepEqual(_.extend({}, func), expected);
func.prototype = { 'c': 3 };
deepEqual(_.extend({}, func), expected);
});
}());
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.forEach');
(function() {
@@ -137,6 +168,15 @@
var collection = [1, 2, 3, 4];
equal(_.forEach(collection, Boolean), collection);
});
test('fixes the JScript [[DontEnum]] bug (test in IE < 9)', function() {
var object = {};
_.forEach(shadowed, function(value, key) {
object[key] = value;
});
deepEqual(object, shadowed);
});
}());
/*--------------------------------------------------------------------------*/
@@ -176,6 +216,17 @@
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.keys');
(function() {
test('fixes the JScript [[DontEnum]] bug (test in IE < 9)', function() {
deepEqual(_.keys(shadowed).sort(),
'constructor hasOwnProperty isPrototypeOf propertyIsEnumerable toLocaleString toString valueOf'.split(' '));
});
}());
/*--------------------------------------------------------------------------*/
_.each(['max', 'min'], function(methodName) {
QUnit.module('lodash.' + methodName);