From e45db2e507b6d2ad1921c233649191ae4a285050 Mon Sep 17 00:00:00 2001 From: John-David Dalton Date: Tue, 10 Jan 2017 19:25:52 -0800 Subject: [PATCH] Remove `baseGetAllKeys`. --- .internal/baseGetAllKeys.js | 19 ------------------- .internal/getAllKeys.js | 4 ++-- .internal/getAllKeysIn.js | 4 ++-- 3 files changed, 4 insertions(+), 23 deletions(-) delete mode 100644 .internal/baseGetAllKeys.js diff --git a/.internal/baseGetAllKeys.js b/.internal/baseGetAllKeys.js deleted file mode 100644 index 32fd1c350..000000000 --- a/.internal/baseGetAllKeys.js +++ /dev/null @@ -1,19 +0,0 @@ -import arrayPush from './.internal/arrayPush.js'; - -/** - * The base implementation of `getAllKeys` and `getAllKeysIn` which uses - * `keysFunc` and `symbolsFunc` to get the enumerable property names and - * symbols of `object`. - * - * @private - * @param {Object} object The object to query. - * @param {Function} keysFunc The function to get the keys of `object`. - * @param {Function} symbolsFunc The function to get the symbols of `object`. - * @returns {Array} Returns the array of property names and symbols. - */ -function baseGetAllKeys(object, keysFunc, symbolsFunc) { - const result = keysFunc(object); - return Array.isArray(object) ? result : arrayPush(result, symbolsFunc(object)); -} - -export default baseGetAllKeys; diff --git a/.internal/getAllKeys.js b/.internal/getAllKeys.js index cafce32c0..1b7069dd5 100644 --- a/.internal/getAllKeys.js +++ b/.internal/getAllKeys.js @@ -1,4 +1,3 @@ -import baseGetAllKeys from './.internal/baseGetAllKeys.js'; import getSymbols from './.internal/getSymbols.js'; import keys from './keys.js'; @@ -10,7 +9,8 @@ import keys from './keys.js'; * @returns {Array} Returns the array of property names and symbols. */ function getAllKeys(object) { - return baseGetAllKeys(object, keys, getSymbols); + const result = keys(object); + return Array.isArray(object) ? result : arrayPush(result, getSymbols(object)); } export default getAllKeys; diff --git a/.internal/getAllKeysIn.js b/.internal/getAllKeysIn.js index 5e23a0bc8..2a38a9543 100644 --- a/.internal/getAllKeysIn.js +++ b/.internal/getAllKeysIn.js @@ -1,4 +1,3 @@ -import baseGetAllKeys from './.internal/baseGetAllKeys.js'; import getSymbolsIn from './.internal/getSymbolsIn.js'; import keysIn from './keysIn.js'; @@ -11,7 +10,8 @@ import keysIn from './keysIn.js'; * @returns {Array} Returns the array of property names and symbols. */ function getAllKeysIn(object) { - return baseGetAllKeys(object, keysIn, getSymbolsIn); + const result = keysIn(object); + return Array.isArray(object) ? result : arrayPush(result, getSymbolsIn(object)); } export default getAllKeysIn;