Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-12 11:57:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

_.isFinite fix and tests

Browse Source
This commit is contained in:
Raymond May Jr
2012-03-25 11:08:23 -05:00
parent 705eff4826
commit e274235865
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/objects.js
View File

@@ -481,6 +481,17 @@ $(document).ready(function() {
ok(_.isRegExp(iRegExp), 'even from another frame'); ok(_.isRegExp(iRegExp), 'even from another frame');
}); });
test("objects: isFinite", function() {
ok(!_.isFinite(undefined), 'undefined is not Finite');
ok(!_.isFinite(null), 'null is not Finite');
ok(!_.isFinite(Infinity), 'Infinity is not Finite');
ok(!_.isFinite(-Infinity), '-Infinity is not Finite');
ok(!_.isFinite('12'), 'Strings are not numbers');
ok(_.isFinite(0), '0 is Finite');
ok(_.isFinite(123), 'Ints are Finite');
ok(_.isFinite(-12.44), 'Floats are Finite');
});
test("objects: isNaN", function() { test("objects: isNaN", function() {
ok(!_.isNaN(undefined), 'undefined is not NaN'); ok(!_.isNaN(undefined), 'undefined is not NaN');
ok(!_.isNaN(null), 'null is not NaN'); ok(!_.isNaN(null), 'null is not NaN');

2
underscore.js
View File

@@ -814,7 +814,7 @@
// Is a givin number finite? // Is a givin number finite?
_.isFinite = function(obj) { _.isFinite = function(obj) {
return obj > -1/0 && obj < 1/0 && obj === -obj; return obj > -1/0 && obj < 1/0 && obj === +obj;
}; };
// Is the given value `NaN`? // Is the given value `NaN`?