mirror of
https://github.com/whoisclebs/lodash.git
synced 2026-02-06 01:47:48 +00:00
Don't mutate array during #remove. [closes #1079]
This commit is contained in:
committed by
jdalton
parent
b1a81a85b1
commit
d2b98323dd
@@ -5310,17 +5310,32 @@
|
||||
function remove(array, predicate, thisArg) {
|
||||
var index = -1,
|
||||
length = array ? array.length : 0,
|
||||
result = [];
|
||||
result = [],
|
||||
removes = 0,
|
||||
indexes = [],
|
||||
last;
|
||||
|
||||
predicate = getCallback(predicate, thisArg, 3);
|
||||
while (++index < length) {
|
||||
var value = array[index];
|
||||
if (predicate(value, index, array)) {
|
||||
if (last && last[0] + last[1] === index) {
|
||||
++last[1];
|
||||
} else {
|
||||
last = [index - removes, 1];
|
||||
indexes.push(last);
|
||||
}
|
||||
result.push(value);
|
||||
splice.call(array, index--, 1);
|
||||
length--;
|
||||
++removes;
|
||||
}
|
||||
}
|
||||
|
||||
index = -1;
|
||||
length = indexes.length;
|
||||
while (++index < length) {
|
||||
last = indexes[index];
|
||||
splice.call(array, last[0], last[1]);
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user