Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-08 02:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update handling of limit to the current es6 draft.

Browse Source
This commit is contained in:
John-David Dalton
2016-04-08 08:48:29 -07:00
parent ee73c9b436
commit c1958daf65
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lodash.js
View File

@@ -13568,7 +13568,7 @@
separator += ''; separator += '';
if (separator == '' && reHasComplexSymbol.test(string)) { if (separator == '' && reHasComplexSymbol.test(string)) {
var strSymbols = stringToArray(string); var strSymbols = stringToArray(string);
return limit === undefined ? strSymbols : strSymbols.slice(0, limit < 0 ? 0 : limit); return limit === undefined ? strSymbols : strSymbols.slice(0, limit >>> 0);
} }
} }
return string.split(separator, limit); return string.split(separator, limit);

5
test/test.js
View File

@@ -23251,7 +23251,7 @@
thumbsUp = '\ud83d\udc4d'; thumbsUp = '\ud83d\udc4d';
QUnit.test('should account for astral symbols', function(assert) { QUnit.test('should account for astral symbols', function(assert) {
assert.expect(32); assert.expect(33);
var allHearts = _.repeat(hearts, 10), var allHearts = _.repeat(hearts, 10),
chars = hearts + comboGlyph, chars = hearts + comboGlyph,
@@ -23274,7 +23274,8 @@
assert.strictEqual(_.size(string), 13); assert.strictEqual(_.size(string), 13);
assert.deepEqual(_.split(string, ' '), ['A', leafs + ',', comboGlyph + ',', 'and', rocket]); assert.deepEqual(_.split(string, ' '), ['A', leafs + ',', comboGlyph + ',', 'and', rocket]);
assert.deepEqual(_.split(string, ' ', 3), ['A', leafs + ',', comboGlyph + ',']); assert.deepEqual(_.split(string, ' ', 3), ['A', leafs + ',', comboGlyph + ',']);
assert.deepEqual(_.split(string, undefined), string.split(undefined)); assert.deepEqual(_.split(string, undefined), [string]);
assert.deepEqual(_.split(string, undefined, -1), [string]);
assert.deepEqual(_.split(string, undefined, 0), string.split(undefined, 0)); assert.deepEqual(_.split(string, undefined, 0), string.split(undefined, 0));
var expected = ['A', ' ', leafs, ',', ' ', comboGlyph, ',', ' ', 'a', 'n', 'd', ' ', rocket]; var expected = ['A', ' ', leafs, ',', ' ', comboGlyph, ',', ' ', 'a', 'n', 'd', ' ', rocket];