Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-08 10:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure assignValue assigns values if they aren't the same own value. [closes #2022]

Browse Source
This commit is contained in:
John-David Dalton
2016-02-18 22:17:49 -08:00
parent 49389d0a2f
commit bfbfa719ff
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lodash.js
View File

@@ -2160,8 +2160,7 @@
*/ */
function assignValue(object, key, value) { function assignValue(object, key, value) {
var objValue = object[key]; var objValue = object[key];
if ((!eq(objValue, value) || if (!(hasOwnProperty.call(object, key) && eq(objValue, value)) ||
(eq(objValue, objectProto[key]) && !hasOwnProperty.call(object, key))) ||
(value === undefined && !(key in object))) { (value === undefined && !(key in object))) {
object[key] = value; object[key] = value;
} }

10
test/test.js
View File

@@ -3497,6 +3497,16 @@
assert.deepEqual(_.create({}, new Foo), { 'a': 1, 'c': 3 }); assert.deepEqual(_.create({}, new Foo), { 'a': 1, 'c': 3 });
}); });
QUnit.test('should assign properties that shadow those of `prototype`', function(assert) {
assert.expect(1);
function Foo() {
this.a = 1;
}
var object = _.create(new Foo, { 'a': 1 });
assert.deepEqual(lodashStable.keys(object), ['a']);
});
QUnit.test('should accept a falsey `prototype` argument', function(assert) { QUnit.test('should accept a falsey `prototype` argument', function(assert) {
assert.expect(1); assert.expect(1);