From ba85d5d351af0138087f94a455b70fe7bb5510fd Mon Sep 17 00:00:00 2001 From: John-David Dalton Date: Mon, 18 Mar 2013 03:06:01 -0600 Subject: [PATCH] Remove the `_.isEqual` dependency from `createCallback` in the `underscore` build and avoid potentially unnecessary string coercion in the `underscore` build `_.isEqual` method. Former-commit-id: 1e8ce4fd9a35ad36c2b24457e519cb587c49c93b --- build.js | 3 ++- dist/lodash.underscore.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/build.js b/build.js index dd77babb9..10b792614 100755 --- a/build.js +++ b/build.js @@ -1731,6 +1731,7 @@ } if (isUnderscore) { dependencyMap.contains = _.without(dependencyMap.contains, 'isString'); + dependencyMap.createCallback = _.without(dependencyMap.createCallback, 'isEqual'); dependencyMap.flatten = _.without(dependencyMap.flatten, 'createCallback'); dependencyMap.isEmpty = ['isArray', 'isString']; dependencyMap.isEqual = _.without(dependencyMap.isEqual, 'forIn', 'isArguments'); @@ -2107,7 +2108,7 @@ '', ' case regexpClass:', ' case stringClass:', - " return a == b + '';", + ' return a == String(b);', ' }', ' var isArr = className == arrayClass;', ' if (!isArr) {', diff --git a/dist/lodash.underscore.js b/dist/lodash.underscore.js index cd01f0653..b843c0675 100644 --- a/dist/lodash.underscore.js +++ b/dist/lodash.underscore.js @@ -1037,7 +1037,7 @@ case regexpClass: case stringClass: - return a == b + ''; + return a == String(b); } var isArr = className == arrayClass; if (!isArr) {