Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-06 01:47:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make _.isArray consistent with the other isType methods.

Browse Source 
Former-commit-id: adcf242ba7692c96fb8f570118acd7fd0a4602da
This commit is contained in:
John-David Dalton
2013-04-15 23:49:17 -07:00
parent bda869ea54
commit b1f8e845df
9 changed files with 316 additions and 294 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
build.js
View File

@@ -1076,7 +1076,7 @@
// remove `argsAreObjects` from `_.isArray`
source = source.replace(matchFunction(source, 'isArray'), function(match) {
return match.replace(/\(support\.argsObject && *([^)]+)\)/g, '$1');
return match.replace(/\(support\.argsObject\s*&&\s*([^)]+)\)/g, '$1');
});
// remove `argsAreObjects` from `_.isEqual`
@@ -1867,7 +1867,7 @@
// remove native `Array.isArray` branch in `_.isArray`
source = source.replace(matchFunction(source, 'isArray'), function(match) {
return match.replace(/nativeIsArray\s*\|\|\s*/, '');
return match.replace(/\s*\(nativeIsArray.+/, ' toString.call(value) == arrayClass;');
});
// replace `_.keys` with `shimKeys`
@@ -2006,6 +2006,11 @@
source = source.replace(/^( *)var eachIteratorOptions *= *[\s\S]+?\n\1};\n/m, function(match) {
return match.replace(/(^ *'arrays':)[^,]+/m, '$1 false');
});
// remove `toString.call` use from `_.isArray`
source = source.replace(matchFunction(source, 'isArray'), function(match) {
return match.replace(/\s*\(nativeIsArray.+/, ' nativeIsArray(value);');
});
}
}
if (isUnderscore) {
@@ -2137,6 +2142,13 @@
'}'
].join('\n'));
// replace `_.isArray`
source = replaceFunction(source, 'isArray', [
'var isArray = nativeIsArray || function(value) {',
' return toString.call(value) == arrayClass;',
'};'
].join('\n'));
// replace `_.isEmpty`
source = replaceFunction(source, 'isEmpty', [
'function isEmpty(value) {',
@@ -2458,6 +2470,14 @@
return match.replace(/\bisEqual\(([^,]+), *([^,]+)[^)]+\)/, '$1 === $2');
});
// remove `instanceof` use from `_.isDate`, `_.isFunction`, and `_.isRegExp`
_.each(['isDate', 'isFunction', 'isRegExp'], function(methodName) {
var snippet = methodName == 'isFunction' ? getIsFunctionFallback(source) : matchFunction(source, methodName);
source = source.replace(snippet, function(match) {
return match.replace(/\w+\s+instanceof\s+\w+\s*\|\|\s*/g, '');
});
});
// remove conditional `charCodeCallback` use from `_.max` and `_.min`
_.each(['max', 'min'], function(methodName) {
source = source.replace(matchFunction(source, methodName), function(match) {
@@ -2480,6 +2500,8 @@
return match.replace(/!\(result *= *(.+?)\);/, '(result = $1) && indicatorObject;');
});
// remove unneeded variables
if (!useLodashMethod('clone') && !useLodashMethod('cloneDeep')) {
source = removeVar(source, 'cloneableClasses');
@@ -2580,6 +2602,7 @@
'setTimeout': setTimeout
});
fs.writeFileSync('lodash.custom.js', source, 'utf-8')
vm.runInContext(source, context);
return context._;
}());