Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-15 21:27:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make "asc" the default order of _.orderBy.

Browse Source
This commit is contained in:
John-David Dalton
2015-12-18 23:12:14 -06:00
parent 7e648741ad
commit 9e99a57615
2 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lodash.js
View File

@@ -999,9 +999,9 @@
* Used by `_.orderBy` to compare multiple properties of a value to another * Used by `_.orderBy` to compare multiple properties of a value to another
* and stable sort them. * and stable sort them.
* *
* If `orders` is unspecified, all valuess are sorted in ascending order. Otherwise, * If `orders` is unspecified, all values are sorted in ascending order. Otherwise,
* a value is sorted in ascending order if its corresponding order is "asc", and * specify an order of "desc" for descending or "asc" for ascending sort order
* descending if "desc". * of corresponding values.
* *
* @private * @private
* @param {Object} object The object to compare. * @param {Object} object The object to compare.
@@ -1023,7 +1023,7 @@
return result; return result;
} }
var order = orders[index]; var order = orders[index];
return result * (order === 'asc' ? 1 : -1); return result * (order === 'desc' ? -1 : 1);
} }
} }
// Fixes an `Array#sort` bug in the JS engine embedded in Adobe applications // Fixes an `Array#sort` bug in the JS engine embedded in Adobe applications
@@ -7640,10 +7640,10 @@
} }
/** /**
* This method is like `_.sortBy` except that it allows specifying the * This method is like `_.sortBy` except that it allows specifying the sort
* sort orders of the iteratees to sort by. If `orders` is unspecified, all * orders of the iteratees to sort by. If `orders` is unspecified, all values
* values are sorted in ascending order. Otherwise, a value is sorted in * are sorted in ascending order. Otherwise, specify an order of "desc" for
* ascending order if its corresponding order is "asc", and descending if "desc". * descending or "asc" for ascending sort order of corresponding values.
* *
* @static * @static
* @memberOf _ * @memberOf _

9
test/test.js
View File

@@ -13536,8 +13536,13 @@
QUnit.test('should sort a property in ascending order when its order is not specified', function(assert) { QUnit.test('should sort a property in ascending order when its order is not specified', function(assert) {
assert.expect(1); assert.expect(1);
var actual = _.orderBy(objects, ['a', 'b'], ['desc']); var expected = lodashStable.map(falsey, lodashStable.constant([objects[3], objects[1], objects[2], objects[0]]));
assert.deepEqual(actual, [objects[3], objects[1], objects[2], objects[0]]);
var actual = lodashStable.map(falsey, function(order, index) {
return _.orderBy(objects, ['a', 'b'], index ? ['desc', order] : ['desc']);
});
assert.deepEqual(actual, expected);
}); });
}()); }());