Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-10 19:07:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add isConcatSpreadable to flatten methods.

Browse Source
This commit is contained in:
John-David Dalton
2016-07-21 08:41:06 -07:00
parent 3c4c06cb5e
commit 984a10c1b1
2 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lodash.js
View File

@@ -1336,10 +1336,11 @@
Symbol = context.Symbol, Symbol = context.Symbol,
Uint8Array = context.Uint8Array, Uint8Array = context.Uint8Array,
enumerate = Reflect ? Reflect.enumerate : undefined, enumerate = Reflect ? Reflect.enumerate : undefined,
iteratorSymbol = typeof (iteratorSymbol = Symbol && Symbol.iterator) == 'symbol' ? iteratorSymbol : undefined, iteratorSymbol = Symbol ? Symbol.iterator : undefined,
objectCreate = context.Object.create, objectCreate = context.Object.create,
propertyIsEnumerable = objectProto.propertyIsEnumerable, propertyIsEnumerable = objectProto.propertyIsEnumerable,
splice = arrayProto.splice; splice = arrayProto.splice,
spreadableSymbol = Symbol ? Symbol.isConcatSpreadable : undefined;
/** Built-in method references that are mockable. */ /** Built-in method references that are mockable. */
var clearTimeout = function(id) { return context.clearTimeout.call(root, id); }, var clearTimeout = function(id) { return context.clearTimeout.call(root, id); },
@@ -5869,7 +5870,8 @@
* @returns {boolean} Returns `true` if `value` is flattenable, else `false`. * @returns {boolean} Returns `true` if `value` is flattenable, else `false`.
*/ */
function isFlattenable(value) { function isFlattenable(value) {
return isArray(value) || isArguments(value); return isArray(value) || isArguments(value) ||
!!(spreadableSymbol && value && value[spreadableSymbol])
} }
/** /**

29
test/test.js
View File

@@ -6505,7 +6505,8 @@
(function() { (function() {
var args = arguments, var args = arguments,
array = [1, [2, [3, [4]], 5]]; array = [1, [2, [3, [4]], 5]],
methodNames = ['flatten', 'flattenDeep', 'flattenDepth'];
QUnit.test('should flatten `arguments` objects', function(assert) { QUnit.test('should flatten `arguments` objects', function(assert) {
assert.expect(3); assert.expect(3);
@@ -6525,12 +6526,34 @@
expected.push(undefined, undefined, undefined); expected.push(undefined, undefined, undefined);
lodashStable.each([_.flatten(array), _.flattenDeep(array), _.flattenDepth(array)], function(actual) { lodashStable.each(methodNames, function(methodName) {
var actual = _[methodName](array);
assert.deepEqual(actual, expected); assert.deepEqual(actual, expected);
assert.ok('4' in actual); assert.ok('4' in actual);
}); });
}); });
QUnit.test('should flatten objects with a truthy `Symbol.isConcatSpreadable` value', function(assert) {
assert.expect(1);
if (Symbol && Symbol.isConcatSpreadable) {
var object = { '0': 'a', 'length': 1 },
array = [object],
expected = lodashStable.map(methodNames, lodashStable.constant(['a']));
object[Symbol.isConcatSpreadable] = true;
var actual = lodashStable.map(methodNames, function(methodName) {
return _[methodName](array);
});
assert.deepEqual(actual, expected);
}
else {
skipAssert(assert);
}
});
QUnit.test('should work with extremely large arrays', function(assert) { QUnit.test('should work with extremely large arrays', function(assert) {
assert.expect(3); assert.expect(3);
@@ -22907,7 +22930,7 @@
QUnit.test('should convert iterables to arrays', function(assert) { QUnit.test('should convert iterables to arrays', function(assert) {
assert.expect(1); assert.expect(1);
if (!isNpm && Symbol && Symbol.iterator) { if (Symbol && Symbol.iterator) {
var object = { '0': 'a', 'length': 1 }; var object = { '0': 'a', 'length': 1 };
object[Symbol.iterator] = arrayProto[Symbol.iterator]; object[Symbol.iterator] = arrayProto[Symbol.iterator];