Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-07 01:57:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize cacheIndexOf, cachePush, and isKeyable.

Browse Source
This commit is contained in:
John-David Dalton
2015-10-03 16:27:21 -07:00
parent 5746169aec
commit 940559fc76
1 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lodash.js
View File

@@ -1836,7 +1836,14 @@
* @returns {number} Returns `0` if `value` is found, else `-1`. * @returns {number} Returns `0` if `value` is found, else `-1`.
*/ */
function cacheIndexOf(cache, value) { function cacheIndexOf(cache, value) {
return cache.__data__.has(value) ? 0 : -1; var map = cache.__data__;
if (isKeyable(value)) {
var data = map.__data__,
hash = typeof value == 'string' ? data.string : data.hash;
return hash[value] === HASH_UNDEFINED ? 0 : -1;
}
return map.has(value) ? 0 : -1;
} }
/** /**
@@ -1848,7 +1855,16 @@
* @param {*} value The value to cache. * @param {*} value The value to cache.
*/ */
function cachePush(value) { function cachePush(value) {
this.__data__.set(value, true); var map = this.__data__;
if (isKeyable(value)) {
var data = map.__data__,
hash = typeof value == 'string' ? data.string : data.hash;
hash[value] = HASH_UNDEFINED;
}
else {
map.set(value, HASH_UNDEFINED);
}
} }
/*------------------------------------------------------------------------*/ /*------------------------------------------------------------------------*/
@@ -4404,7 +4420,9 @@
* @returns {boolean} Returns `true` if `value` is suitable, else `false`. * @returns {boolean} Returns `true` if `value` is suitable, else `false`.
*/ */
function isKeyable(value) { function isKeyable(value) {
return !(value === '__proto__' || isObject(value)); var type = typeof value;
return type == 'number' || type == 'boolean' ||
(type == 'string' && value !== '__proto__') || value == null;
} }
/** /**