Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-11 11:27:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Should not ignore empty brackes and dots.

Browse Source
This commit is contained in:
John-David Dalton
2016-05-20 08:42:03 -07:00
parent 68ae6fc212
commit 91242440fc
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lodash.js
View File

@@ -116,7 +116,7 @@
/** Used to match property names within property paths. */ /** Used to match property names within property paths. */
var reIsDeepProp = /\.|\[(?:[^[\]]*|(["'])(?:(?!\1)[^\\]|\\.)*?\1)\]/, var reIsDeepProp = /\.|\[(?:[^[\]]*|(["'])(?:(?!\1)[^\\]|\\.)*?\1)\]/,
reIsPlainProp = /^\w*$/, reIsPlainProp = /^\w*$/,
rePropName = /[^.[\]]+|\[(?:(-?\d+(?:\.\d+)?)|(["'])((?:(?!\2)[^\\]|\\.)*?)\2)\]/g; rePropName = /[^.[\]]+|\[(?:(-?\d+(?:\.\d+)?)|(["'])((?:(?!\2)[^\\]|\\.)*?)\2)\]|(?=(\.|\[\])(?:\4|$))/g;
/** /**
* Used to match `RegExp` * Used to match `RegExp`

14
test/test.js
View File

@@ -19273,10 +19273,10 @@
assert.strictEqual(func(object, ['a', 'b', 'c']), 4); assert.strictEqual(func(object, ['a', 'b', 'c']), 4);
}); });
QUnit.test('`_.' + methodName + '` should ignore empty brackets', function(assert) { QUnit.test('`_.' + methodName + '` should not ignore empty brackets', function(assert) {
assert.expect(1); assert.expect(1);
var object = { 'a': 1 }; var object = { 'a': { '': 1 } };
assert.strictEqual(func(object, 'a[]'), 1); assert.strictEqual(func(object, 'a[]'), 1);
}); });
@@ -19962,13 +19962,13 @@
assert.strictEqual(object.a.b.c, value); assert.strictEqual(object.a.b.c, value);
}); });
QUnit.test('`_.' + methodName + '` should ignore empty brackets', function(assert) { QUnit.test('`_.' + methodName + '` should not ignore empty brackets', function(assert) {
assert.expect(1); assert.expect(1);
var object = {}; var object = {};
func(object, 'a[]', updater); func(object, 'a[]', updater);
assert.deepEqual(object, { 'a': value }); assert.deepEqual(object, { 'a': { '': value } });
}); });
QUnit.test('`_.' + methodName + '` should handle empty paths', function(assert) { QUnit.test('`_.' + methodName + '` should handle empty paths', function(assert) {
@@ -23723,14 +23723,14 @@
assert.deepEqual(actual, ['a', '-1.23', '["b"]', 'c', "['d']", '\ne\n', 'f', 'g']); assert.deepEqual(actual, ['a', '-1.23', '["b"]', 'c', "['d']", '\ne\n', 'f', 'g']);
}); });
QUnit.test('should ignore consecutive brackets and dots', function(assert) { QUnit.test('should not ignore consecutive brackets and dots', function(assert) {
assert.expect(4); assert.expect(4);
var expected = ['a']; var expected = ['a', ''];
assert.deepEqual(_.toPath('a.'), expected); assert.deepEqual(_.toPath('a.'), expected);
assert.deepEqual(_.toPath('a[]'), expected); assert.deepEqual(_.toPath('a[]'), expected);
expected = ['a', 'b']; expected = ['a', '', 'b'];
assert.deepEqual(_.toPath('a..b'), expected); assert.deepEqual(_.toPath('a..b'), expected);
assert.deepEqual(_.toPath('a[][]b'), expected); assert.deepEqual(_.toPath('a[][]b'), expected);
}); });