Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-13 12:27:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add v8 issue note to parseInt and make other v8 issue use the same protocol. [ci skip]

Browse Source
This commit is contained in:
John-David Dalton
2014-02-11 18:57:48 -08:00
parent b16b49aea4
commit 8558c55284
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lodash.js
View File

@@ -344,7 +344,7 @@
// for `a` and `b`. See https://github.com/jashkenas/underscore/pull/1247 // for `a` and `b`. See https://github.com/jashkenas/underscore/pull/1247
// //
// This also ensures a stable sort in V8 and other engines. // This also ensures a stable sort in V8 and other engines.
// See http://code.google.com/p/v8/issues/detail?id=90 // See https://code.google.com/p/v8/issues/detail?id=90
return a.index - b.index; return a.index - b.index;
} }
@@ -6083,7 +6083,7 @@
// check if the value is the ECMAScript language type of Object // check if the value is the ECMAScript language type of Object
// http://es5.github.io/#x8 // http://es5.github.io/#x8
// and avoid a V8 bug // and avoid a V8 bug
// http://code.google.com/p/v8/issues/detail?id=2291 // https://code.google.com/p/v8/issues/detail?id=2291
var type = typeof value; var type = typeof value;
return value && (type == 'function' || type == 'object') || false; return value && (type == 'function' || type == 'object') || false;
} }
@@ -7244,8 +7244,9 @@
* // => 8 * // => 8
*/ */
var parseInt = nativeParseInt(whitespace + '08') == 8 ? nativeParseInt : function(value, radix) { var parseInt = nativeParseInt(whitespace + '08') == 8 ? nativeParseInt : function(value, radix) {
// Firefox < 21 and Opera < 15 follow ES3 for `parseInt` and
// Chrome fails to trim leading <BOM> whitespace characters. // Chrome fails to trim leading <BOM> whitespace characters.
// Firefox < 21 and Opera < 15 follow the ES3 specified implementation of `parseInt`. // See https://code.google.com/p/v8/issues/detail?id=3109
value = trim(value); value = trim(value);
return nativeParseInt(value, +radix || (reHexPrefix.test(value) ? 16 : 10)); return nativeParseInt(value, +radix || (reHexPrefix.test(value) ? 16 : 10));
}; };