Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-08 10:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

bug fix for _.memoize when key is derived from prototype

Browse Source
This commit is contained in:
lifesinger
2011-01-17 14:57:02 +08:00
parent 52f66a807c
commit 840f19c102
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/functions.js
View File

@@ -52,6 +52,13 @@ $(document).ready(function() {
var fastFib = _.memoize(fib); var fastFib = _.memoize(fib);
equals(fib(10), 55, 'a memoized version of fibonacci produces identical results'); equals(fib(10), 55, 'a memoized version of fibonacci produces identical results');
equals(fastFib(10), 55, 'a memoized version of fibonacci produces identical results'); equals(fastFib(10), 55, 'a memoized version of fibonacci produces identical results');
var o = function(str) {
return str;
};
var fastO = _.memoize(o);
equals(o('toString'), 'toString', 'checks hasOwnProperty');
equals(fastO('toString'), 'toString', 'checks hasOwnProperty');
}); });
asyncTest("functions: delay", 2, function() { asyncTest("functions: delay", 2, function() {

2
underscore.js
View File

@@ -426,7 +426,7 @@
hasher = hasher || _.identity; hasher = hasher || _.identity;
return function() { return function() {
var key = hasher.apply(this, arguments); var key = hasher.apply(this, arguments);
return key in memo ? memo[key] : (memo[key] = func.apply(this, arguments)); return hasOwnProperty.call(memo, key) ? memo[key] : (memo[key] = func.apply(this, arguments));
}; };
}; };