Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-10 19:07:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure _.flow and _.flowRight return an identity function when no arguments are provided. [closes #938]

Browse Source
This commit is contained in:
jdalton
2015-02-06 22:45:58 -08:00
parent 35fa977981
commit 82c7a22d27
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lodash.src.js
View File

@@ -7207,7 +7207,7 @@
length = funcs.length; length = funcs.length;
if (!length) { if (!length) {
return function() {}; return function() { return arguments[0]; };
} }
if (!arrayEvery(funcs, isFunction)) { if (!arrayEvery(funcs, isFunction)) {
throw new TypeError(FUNC_ERROR_TEXT); throw new TypeError(FUNC_ERROR_TEXT);
@@ -7252,7 +7252,7 @@
fromIndex = funcs.length - 1; fromIndex = funcs.length - 1;
if (fromIndex < 0) { if (fromIndex < 0) {
return function() {}; return function() { return arguments[0]; };
} }
if (!arrayEvery(funcs, isFunction)) { if (!arrayEvery(funcs, isFunction)) {
throw new TypeError(FUNC_ERROR_TEXT); throw new TypeError(FUNC_ERROR_TEXT);

6
test/test.js
View File

@@ -2023,15 +2023,15 @@
notStrictEqual(func(_.noop), _.noop); notStrictEqual(func(_.noop), _.noop);
}); });
test('`_.' + methodName + '` should return a noop function when no arguments are provided', 2, function() { test('`_.' + methodName + '` should return an identity function when no arguments are provided', 2, function() {
var combined = func(); var combined = func();
try { try {
strictEqual(combined(), undefined); strictEqual(combined('a'), 'a');
} catch(e) { } catch(e) {
ok(false, e.message); ok(false, e.message);
} }
notStrictEqual(combined, _.noop); notStrictEqual(combined, _.identity);
}); });
test('`_.' + methodName + '` should return a wrapped value when chaining', 1, function() { test('`_.' + methodName + '` should return a wrapped value when chaining', 1, function() {