Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-01 07:47:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove propertyDeep, propertyDeepOf, and resultDeep in favor of deep property path support in existing methods.

Browse Source
This commit is contained in:
jdalton
2015-03-28 13:16:16 -07:00
parent 3d0beb1a2e
commit 8218b74fb3
2 changed files with 41 additions and 267 deletions
Download Patch File Download Diff File Expand all files Collapse all files

135
test/test.js
View File

@@ -11588,58 +11588,6 @@
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.propertyDeep');
(function() {
test('should create a function that plucks a property value of a given object', 3, function() {
var object = { 'a': [1, 2], 'b': 3 },
prop = _.propertyDeep(['a', 1]);
strictEqual(prop.length, 1);
strictEqual(prop(object), 2);
prop = _.propertyDeep(['b']);
strictEqual(prop(object), 3);
});
test('should work with non-string `prop` arguments', 1, function() {
var prop = _.propertyDeep([1]);
strictEqual(prop([1, 2, 3]), 2);
});
test('should return a function even for falsey values', 1, function() {
var pass = true;
_.each(falsey, function(keys) {
pass = typeof _.propertyDeep(keys) == 'function'
});
ok(pass);
});
test('should pluck inherited property values', 1, function() {
function Foo() { this.a = 1; }
Foo.prototype.b = 2;
var prop = _.propertyDeep(['b']);
strictEqual(prop(new Foo), 2);
});
test('should work when `object` is nullish', 1, function() {
var values = [, null, undefined],
expected = _.map(values, _.constant(undefined));
var actual = _.map(values, function(value, index) {
var prop = _.propertyDeep(['a']);
return index ? prop(value) : prop();
});
deepEqual(actual, expected);
});
}());
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.propertyOf');
(function() {
@@ -11675,41 +11623,6 @@
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.propertyDeepOf');
(function() {
test('should create a function that plucks a property value of a given key', 3, function() {
var object = { 'a': 1, 'b': 2 },
propOf = _.propertyDeepOf(object);
strictEqual(propOf.length, 1);
strictEqual(propOf(['a']), 1);
strictEqual(propOf(['b']), 2);
});
test('should pluck inherited property values', 1, function() {
function Foo() { this.a = 1; }
Foo.prototype.b = 2;
var propOf = _.propertyDeepOf(new Foo);
strictEqual(propOf(['b']), 2);
});
test('should work when `object` is nullish', 1, function() {
var values = [, null, undefined],
expected = _.map(values, _.constant(undefined));
var actual = _.map(values, function(value, index) {
var propOf = index ? _.propertyDeepOf(value) : _.propertyDeepOf();
return propOf(['a']);
});
deepEqual(actual, expected);
});
}());
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.pull');
(function() {
@@ -12588,52 +12501,6 @@
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.resultDeep');
(function() {
var object = {
'a': { d: 1 },
'b': null,
'c': function() { return this.a; }
};
test('should resolve property values', 4, function() {
strictEqual(_.resultDeep(object, ['a', 'd']), 1);
strictEqual(_.resultDeep(object, ['b']), null);
strictEqual(_.resultDeep(object, ['c', 'd']), 1);
strictEqual(_.resultDeep(object, ['d']), undefined);
});
test('should return `undefined` when `object` is nullish', 2, function() {
strictEqual(_.resultDeep(null, ['a']), undefined);
strictEqual(_.resultDeep(undefined, ['a']), undefined);
});
test('should return the specified default value for undefined properties', 1, function() {
var values = empties.concat(true, new Date, 1, /x/, 'a');
var expected = _.transform(values, function(result, value) {
result.push(value, value);
});
var actual = _.transform(values, function(result, value) {
result.push(
_.resultDeep(object, ['d'], value),
_.resultDeep(null, ['d'], value)
);
});
deepEqual(actual, expected);
});
test('should execute default function values', 1, function() {
var actual = _.resultDeep(object, ['d'], object.c);
strictEqual(actual, object.a);
});
}());
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.rest');
(function() {
@@ -16668,7 +16535,7 @@
var acceptFalsey = _.difference(allMethods, rejectFalsey);
test('should accept falsey arguments', 216, function() {
test('should accept falsey arguments', 213, function() {
var emptyArrays = _.map(falsey, _.constant([])),
isExposed = '_' in root,
oldDash = root._;