From 801c4a56c32f1c76c2e9c58bdac2ed4853beef81 Mon Sep 17 00:00:00 2001 From: John-David Dalton Date: Tue, 19 Jul 2016 17:55:31 -0700 Subject: [PATCH] Remove old browser `addListener` helper. --- perf/asset/perf-ui.js | 25 +++---------------------- test/asset/test-ui.js | 25 +++---------------------- 2 files changed, 6 insertions(+), 44 deletions(-) diff --git a/perf/asset/perf-ui.js b/perf/asset/perf-ui.js index e3ed64b24..f368c6c6d 100644 --- a/perf/asset/perf-ui.js +++ b/perf/asset/perf-ui.js @@ -15,27 +15,8 @@ /*--------------------------------------------------------------------------*/ - /** - * Registers an event listener on an element. - * - * @private - * @param {Element} element The element. - * @param {string} eventName The name of the event. - * @param {Function} handler The event handler. - * @returns {Element} The element. - */ - function addListener(element, eventName, handler) { - if (typeof element.addEventListener != 'undefined') { - element.addEventListener(eventName, handler, false); - } else if (typeof element.attachEvent != 'undefined') { - element.attachEvent('on' + eventName, handler); - } - } - - /*--------------------------------------------------------------------------*/ - // Initialize controls. - addListener(window, 'load', function() { + addEventListener('load', function() { function eventHandler(event) { var buildIndex = buildList.selectedIndex, otherIndex = otherList.selectedIndex, @@ -96,8 +77,8 @@ return -1; }()); - addListener(buildList, 'change', eventHandler); - addListener(otherList, 'change', eventHandler); + buildList.addEventListener('change', eventHandler); + otherList.addEventListener('change', eventHandler); }); // The lodash build file path. diff --git a/test/asset/test-ui.js b/test/asset/test-ui.js index 39694ad18..968f0f8ec 100644 --- a/test/asset/test-ui.js +++ b/test/asset/test-ui.js @@ -15,27 +15,8 @@ /*--------------------------------------------------------------------------*/ - /** - * Registers an event listener on an element. - * - * @private - * @param {Element} element The element. - * @param {string} eventName The name of the event. - * @param {Function} handler The event handler. - * @returns {Element} The element. - */ - function addListener(element, eventName, handler) { - if (typeof element.addEventListener != 'undefined') { - element.addEventListener(eventName, handler, false); - } else if (typeof element.attachEvent != 'undefined') { - element.attachEvent('on' + eventName, handler); - } - } - - /*--------------------------------------------------------------------------*/ - // Initialize controls. - addListener(window, 'load', function() { + addEventListener('load', function() { function eventHandler(event) { var buildIndex = buildList.selectedIndex, loaderIndex = loaderList.selectedIndex, @@ -84,8 +65,8 @@ return -1; }()); - addListener(buildList, 'change', eventHandler); - addListener(loaderList, 'change', eventHandler); + buildList.addEventListener('change', eventHandler); + loaderList.addEventListener('change', eventHandler); } var span1 = document.createElement('span');