Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-11 11:27:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Issue #329, special check for the common and magical 'length' property.

Browse Source
This commit is contained in:
Jeremy Ashkenas
2011-10-18 23:26:59 -04:00
parent 86eedd2a7b
commit 7fc616943e
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/objects.js
View File

@@ -183,7 +183,7 @@ $(document).ready(function() {
// Sparse arrays. // Sparse arrays.
ok(_.isEqual(Array(3), Array(3)), "Sparse arrays of identical lengths are equal"); ok(_.isEqual(Array(3), Array(3)), "Sparse arrays of identical lengths are equal");
ok(_.isEqual(Array(3), Array(6)), "Sparse arrays of different lengths are equal when both are empty"); ok(!_.isEqual(Array(3), Array(6)), "Sparse arrays of different lengths are not equal when both are empty");
// According to the Microsoft deviations spec, section 2.1.26, JScript 5.x treats `undefined` // According to the Microsoft deviations spec, section 2.1.26, JScript 5.x treats `undefined`
// elements in arrays as elisions. Thus, sparse arrays and dense arrays containing `undefined` // elements in arrays as elisions. Thus, sparse arrays and dense arrays containing `undefined`

2
underscore.js
View File

@@ -675,6 +675,8 @@
} }
// Ensure that both values are objects. // Ensure that both values are objects.
if (typeA != 'object') return false; if (typeA != 'object') return false;
// Arrays or Arraylikes with different lengths are not equal.
if (a.length !== b.length) return false;
// Objects with different constructors are not equal. // Objects with different constructors are not equal.
if (a.constructor !== b.constructor) return false; if (a.constructor !== b.constructor) return false;
// Assume equality for cyclic structures. The algorithm for detecting cyclic structures is // Assume equality for cyclic structures. The algorithm for detecting cyclic structures is