Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-08 10:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update fp map for assignment methods and set methods. [closes #1754]

Browse Source
This commit is contained in:
John-David Dalton
2016-01-13 00:05:11 -08:00
parent 0fc6929dd4
commit 79c873f3f8
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/fp/mapping.js
View File

@@ -109,7 +109,8 @@ module.exports = {
'clamp': [2, 0, 1], 'clamp': [2, 0, 1],
'reduce': [2, 0, 1], 'reduce': [2, 0, 1],
'reduceRight': [2, 0, 1], 'reduceRight': [2, 0, 1],
'setWith': [3, 2, 1, 0], 'set': [2, 0, 1],
'setWith': [3, 1, 2, 0],
'slice': [2, 0, 1], 'slice': [2, 0, 1],
'transform': [2, 0, 1] 'transform': [2, 0, 1]
}, },
@@ -153,8 +154,14 @@ module.exports = {
/** Used to track methods that skip `_.rearg`. */ /** Used to track methods that skip `_.rearg`. */
'skipReargMap': { 'skipReargMap': {
'assign': true,
'assignIn': true,
'defaults': true,
'defaultsDeep': true,
'difference': true, 'difference': true,
'extend': true,
'matchesProperty': true, 'matchesProperty': true,
'merge': true,
'random': true, 'random': true,
'range': true, 'range': true,
'rangeRight': true, 'rangeRight': true,

8
test/test-fp.js
View File

@@ -743,14 +743,14 @@
assert.deepEqual(actual, { 'a': 1, 'b': 2 }, 'fp.assignWith'); assert.deepEqual(actual, { 'a': 1, 'b': 2 }, 'fp.assignWith');
value = _.clone(object); value = _.clone(object);
actual = fp.defaults({ 'a': 2, 'b': 2 }, value); actual = fp.defaults(value, { 'a': 2, 'b': 2 });
assert.deepEqual(value, object, 'fp.defaults'); assert.deepEqual(value, object, 'fp.defaults');
assert.deepEqual(actual, { 'a': 1, 'b': 2 }, 'fp.defaults'); assert.deepEqual(actual, { 'a': 1, 'b': 2 }, 'fp.defaults');
value = _.clone(object); value = _.clone(object);
value.b = { 'c': 1 }; value.b = { 'c': 1 };
actual = fp.defaultsDeep({ 'b': { 'c': 2, 'd': 2 } }, value); actual = fp.defaultsDeep(value, { 'b': { 'c': 2, 'd': 2 } });
assert.deepEqual(value, { 'a': 1, 'b': { 'c': 1 } } , 'fp.defaultsDeep'); assert.deepEqual(value, { 'a': 1, 'b': { 'c': 1 } } , 'fp.defaultsDeep');
assert.deepEqual(actual, { 'a': 1, 'b': { 'c': 1, 'd': 2 } }, 'fp.defaultsDeep'); assert.deepEqual(actual, { 'a': 1, 'b': { 'c': 1, 'd': 2 } }, 'fp.defaultsDeep');
@@ -824,13 +824,13 @@
assert.deepEqual(actual, [3, 2, 1], 'fp.reverse'); assert.deepEqual(actual, [3, 2, 1], 'fp.reverse');
value = _.cloneDeep(deepObject); value = _.cloneDeep(deepObject);
actual = fp.set(3, 'a.b', value); actual = fp.set('a.b', 3, value);
assert.deepEqual(value, deepObject, 'fp.set'); assert.deepEqual(value, deepObject, 'fp.set');
assert.deepEqual(actual, { 'a': { 'b': 3, 'c': 3 } }, 'fp.set'); assert.deepEqual(actual, { 'a': { 'b': 3, 'c': 3 } }, 'fp.set');
value = _.cloneDeep(deepObject); value = _.cloneDeep(deepObject);
actual = fp.setWith(Object, 4, 'd.e', value); actual = fp.setWith(Object, 'd.e', 4, value);
assert.deepEqual(value, deepObject, 'fp.setWith'); assert.deepEqual(value, deepObject, 'fp.setWith');
assert.deepEqual(actual, { 'a': { 'b': 2, 'c': 3 }, 'd': { 'e': 4 } }, 'fp.setWith'); assert.deepEqual(actual, { 'a': { 'b': 2, 'c': 3 }, 'd': { 'e': 4 } }, 'fp.setWith');