Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-09 18:37:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure _.indexOf and _.lastIndexOf return -1 when performing a binary search for undefined and it's not found. [closes #1303]

Browse Source
This commit is contained in:
jdalton
2015-06-25 14:34:04 -07:00
parent 67359c22d5
commit 6b7c1ad6cf
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lodash.src.js
View File

@@ -5089,10 +5089,9 @@
if (typeof fromIndex == 'number') { if (typeof fromIndex == 'number') {
fromIndex = fromIndex < 0 ? nativeMax(length + fromIndex, 0) : fromIndex; fromIndex = fromIndex < 0 ? nativeMax(length + fromIndex, 0) : fromIndex;
} else if (fromIndex) { } else if (fromIndex) {
var index = binaryIndex(array, value), var index = binaryIndex(array, value);
other = array[index]; if (index < length &&
(value === value ? (value === array[index]) : (array[index] !== array[index]))) {
if (value === value ? (value === other) : (other !== other)) {
return index; return index;
} }
return -1; return -1;

3
test/test.js
View File

@@ -9354,12 +9354,13 @@
deepEqual(actual, expected); deepEqual(actual, expected);
}); });
test('`_.' + methodName + '` should return `-1` for an unmatched value', 4, function() { test('`_.' + methodName + '` should return `-1` for an unmatched value', 5, function() {
var array = [1, 2, 3], var array = [1, 2, 3],
empty = []; empty = [];
strictEqual(func(array, 4), -1); strictEqual(func(array, 4), -1);
strictEqual(func(array, 4, true), -1); strictEqual(func(array, 4, true), -1);
strictEqual(func(array, undefined, true), -1);
strictEqual(func(empty, undefined), -1); strictEqual(func(empty, undefined), -1);
strictEqual(func(empty, undefined, true), -1); strictEqual(func(empty, undefined, true), -1);