Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-10 10:57:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove argument juggling from _.before.

Browse Source
This commit is contained in:
John-David Dalton
2015-07-29 23:22:13 -07:00
parent b17f6eee6a
commit 693704a832
2 changed files with 1 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lodash.js
View File

@@ -6648,13 +6648,7 @@
function before(n, func) { function before(n, func) {
var result; var result;
if (typeof func != 'function') { if (typeof func != 'function') {
if (typeof n == 'function') { throw new TypeError(FUNC_ERROR_TEXT);
var temp = n;
n = func;
func = temp;
} else {
throw new TypeError(FUNC_ERROR_TEXT);
}
} }
return function() { return function() {
if (--n > 0) { if (--n > 0) {

12
test/test.js
View File

@@ -1190,18 +1190,6 @@
deepEqual(actual, expected); deepEqual(actual, expected);
}); });
test('should allow `func` as the first argument', 1, function() {
var count = 0;
try {
var before = _.before(function() { count++; }, 2);
before();
before();
} catch(e) {}
strictEqual(count, 1);
});
test('should not set a `this` binding', 2, function() { test('should not set a `this` binding', 2, function() {
var before = _.before(2, function() { return ++this.count; }), var before = _.before(2, function() { return ++this.count; }),
object = { 'count': 0, 'before': before }; object = { 'count': 0, 'before': before };