Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-09 02:17:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add lazy _.compact test and cleanup previous fix.

Browse Source
This commit is contained in:
John-David Dalton
2014-11-21 01:33:38 -08:00
parent 1705bf4f3c
commit 5f7dcc9b78
2 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lodash.js
View File

@@ -10266,7 +10266,9 @@
: lodash[methodName](this.value()); : lodash[methodName](this.value());
} }
if (isLazy || isArray(value)) { if (isLazy || isArray(value)) {
var result = func.apply(isLazy && !this.__queue__.length ? value : new LazyWrapper(this), args); var wrapper = (isLazy && !this.__queue__.length) ? value : new LazyWrapper(this),
result = func.apply(wrapper, args);
return new LodashWrapper(result, chainAll); return new LodashWrapper(result, chainAll);
} }
return this.thru(function(value) { return this.thru(function(value) {

17
test/test.js
View File

@@ -1894,9 +1894,10 @@
deepEqual(_.compact(falsey.concat(array)), array); deepEqual(_.compact(falsey.concat(array)), array);
}); });
test('should filter falsey values when in between lazy operators', 1, function () { test('should return a wrapped value when chaining', 2, function() {
if (!isNpm) { if (!isNpm) {
var wrapped = _(falsey).map(_.identity).compact().map(_.identity); var wrapped = _(falsey).compact();
ok(wrapped instanceof _);
deepEqual(wrapped.value(), []); deepEqual(wrapped.value(), []);
} }
else { else {
@@ -1904,11 +1905,13 @@
} }
}); });
test('should return a wrapped value when chaining', 2, function() { test('should work when in between lazy operators', 2, function() {
if (!isNpm) { if (!isNpm) {
var wrapped = _(falsey).compact(); var actual = _(falsey).map().compact().map().value();
ok(wrapped instanceof _); deepEqual(actual, []);
deepEqual(wrapped.value(), []);
actual = _(falsey).map().push(true, 1).compact().push('a').map().value();
deepEqual(actual, [true, 1, 'a']);
} }
else { else {
skipTest(2); skipTest(2);
@@ -3565,7 +3568,7 @@
}); });
test('should return `true` if `predicate` returns truthy for all elements in the collection', 1, function() { test('should return `true` if `predicate` returns truthy for all elements in the collection', 1, function() {
strictEqual(_.every([true, 1, 'x'], _.identity), true); strictEqual(_.every([true, 1, 'a'], _.identity), true);
}); });
test('should return `false` as soon as `predicate` returns falsey', 1, function() { test('should return `false` as soon as `predicate` returns falsey', 1, function() {