Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-14 12:47:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove _.identity from binaryIndex.

Browse Source
This commit is contained in:
John-David Dalton
2014-12-17 23:27:27 -08:00
parent 70b00dc4e3
commit 56a11910db
1 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
lodash.js
View File

@@ -1727,20 +1727,22 @@
} }
/** /**
* The base implementation of `binaryIndex`, without support for invoking * The base implementation of `binaryIndex` which supports large arrays and
* `iteratee` for `value`, which supports large arrays and determining the * determining the insert index for `NaN` and `undefined`.
* insert index for `NaN` and `undefined`.
* *
* @private * @private
* @param {Array} array The sorted array to inspect. * @param {Array} array The sorted array to inspect.
* @param {*} value The value to evaluate. * @param {*} value The value to evaluate.
* @param {Function} iteratee The function invoked per iteration. * @param {Function} [iteratee=_.identity] The function invoked per iteration.
* @param {boolean} [retHighest=false] Specify returning the highest, instead * @param {boolean} [retHighest=false] Specify returning the highest, instead
* of the lowest, index at which a value should be inserted into `array`. * of the lowest, index at which a value should be inserted into `array`.
* @returns {number} Returns the index at which `value` should be inserted * @returns {number} Returns the index at which `value` should be inserted
* into `array`. * into `array`.
*/ */
function baseBinaryIndex(array, value, iteratee, retHighest) { function baseBinaryIndex(array, value, iteratee, retHighest) {
iteratee = iteratee == null ? identity : iteratee;
value = iteratee(value);
var low = 0, var low = 0,
high = array ? array.length : low, high = array ? array.length : low,
valIsNaN = value !== value, valIsNaN = value !== value,
@@ -2659,14 +2661,15 @@
/** /**
* Performs a binary search of `array` to determine the index at which `value` * Performs a binary search of `array` to determine the index at which `value`
* should be inserted into `array` in order to maintain its sort order. The * should be inserted into `array` in order to maintain its sort order. If
* iteratee function is invoked for `value` and each element of `array` to * `iteratee` is provided it is invoked for `value` and each element of
* compute their sort ranking. The iteratee is invoked with one argument; (value). * `array` to compute their sort ranking. The iteratee is invoked with one
* argument; (value).
* *
* @private * @private
* @param {Array} array The sorted array to inspect. * @param {Array} array The sorted array to inspect.
* @param {*} value The value to evaluate. * @param {*} value The value to evaluate.
* @param {Function} [iteratee=_.identity] The function invoked per iteration. * @param {Function} [iteratee] The function invoked per iteration.
* @param {boolean} [retHighest=false] Specify returning the highest, instead * @param {boolean} [retHighest=false] Specify returning the highest, instead
* of the lowest, index at which a value should be inserted into `array`. * of the lowest, index at which a value should be inserted into `array`.
* @returns {number} Returns the index at which `value` should be inserted * @returns {number} Returns the index at which `value` should be inserted
@@ -2676,14 +2679,12 @@
var low = 0, var low = 0,
high = array ? array.length : low; high = array ? array.length : low;
iteratee = iteratee == null ? identity : iteratee; if (iteratee || value !== value || typeof value == 'undefined' || high > HALF_MAX_ARRAY_LENGTH) {
value = iteratee(value);
if (value !== value || typeof value == 'undefined' || high > HALF_MAX_ARRAY_LENGTH) {
return baseBinaryIndex(array, value, iteratee, retHighest); return baseBinaryIndex(array, value, iteratee, retHighest);
} }
while (low < high) { while (low < high) {
var mid = (low + high) >>> 1, var mid = (low + high) >>> 1,
computed = iteratee(array[mid]); computed = array[mid];
if (retHighest ? (computed <= value) : (computed < value)) { if (retHighest ? (computed <= value) : (computed < value)) {
low = mid + 1; low = mid + 1;