Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-06 09:47:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize _.isArray fallback, baseFlatten, & _.isArguments for plain objects.

Browse Source
This commit is contained in:
John-David Dalton
2013-09-17 08:58:18 -07:00
parent 9f2b1b03d7
commit 55f080e33f
8 changed files with 116 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
dist/lodash.underscore.js vendored
View File

@@ -419,8 +419,8 @@
while (++index < length) {
var value = array[index];
// recursively flatten arrays (susceptible to call stack limits)
if (value && typeof value == 'object' && (isArray(value) || isArguments(value))) {
if (value && typeof value == 'object' && value.length && (isArray(value) || isArguments(value))) {
// recursively flatten arrays (susceptible to call stack limits)
if (!isShallow) {
value = baseFlatten(value, isShallow, isArgArrays);
}
@@ -784,12 +784,14 @@
* // => false
*/
function isArguments(value) {
return (value && typeof value == 'object') ? toString.call(value) == argsClass : false;
return value && typeof value == 'object' && typeof value.length == 'number' &&
toString.call(value) == argsClass || false;
}
// fallback for browsers that can't detect `arguments` objects by [[Class]]
if (!isArguments(arguments)) {
isArguments = function(value) {
return (value && typeof value == 'object') ? hasOwnProperty.call(value, 'callee') : false;
return value && typeof value == 'object' && typeof value.length == 'number' &&
hasOwnProperty.call(value, 'callee') || false;
};
}
@@ -811,7 +813,8 @@
* // => true
*/
var isArray = nativeIsArray || function(value) {
return (value && typeof value == 'object') ? toString.call(value) == arrayClass : false;
return value && typeof value == 'object' && typeof value.length == 'number' &&
toString.call(value) == arrayClass || false;
};
/**