From 447e43e8f409d267663c88c257610ef3c6b26649 Mon Sep 17 00:00:00 2001
From: John-David Dalton <john.david.dalton@gmail.com>
Date: Wed, 24 Oct 2012 19:49:26 -0700
Subject: [PATCH] Remove chainability from `_.forEach` in the `lodash
 underscore` build.

Former-commit-id: 1db7daafacddcf78492643d6c6301af706b92150
---
 build.js                 |  5 +++++
 lodash.underscore.min.js |  4 ++--
 test/test-build.js       | 18 ++++++++++--------
 3 files changed, 17 insertions(+), 10 deletions(-)

diff --git a/build.js b/build.js
index 2bfe33dbd..b654d8fb1 100755
--- a/build.js
+++ b/build.js
@@ -1327,6 +1327,11 @@
             });
           }());
 
+          // remove chainability from `_.forEach`
+          source = source.replace(matchFunction(source, 'forEach'), function(match) {
+            return match.replace(/return result([};\s]+)$/, '$1');
+          });
+
           // unexpose "exit early" feature from `_.forEach`, `_.forIn`, and `_.forOwn`
           _.each(['forEach', 'forIn', 'forOwn'], function(methodName) {
             source = source.replace(matchFunction(source, methodName), function(match) {
diff --git a/lodash.underscore.min.js b/lodash.underscore.min.js
index de12e73ff..786ca016a 100644
--- a/lodash.underscore.min.js
+++ b/lodash.underscore.min.js
@@ -2,8 +2,8 @@
  Lo-Dash 0.9.0 lodash.com/license
  Underscore.js 1.4.2 underscorejs.org/LICENSE
 */
-;(function(e,t){function s(e,t,n){var r;if(!e)return e;var t=p(t,n),i=e.length,n=-1;if("number"==typeof i)for(;++n<i&&(r=e[n],t(r,n,e)!==J););else for(n in e)if(it.call(e,n)&&(r=e[n],t(r,n,e)===J))break;return e}function o(e){var t,n,r=e;if(!e)return e;for(var i=1,s=arguments.length;i<s;i++)if(r=arguments[i])for(t in r)n=r[t],e[t]=n;return e}function u(e){var t,n,i=e;if(!e)return e;for(var s=1,o=arguments.length;s<o;s++)if(i=arguments[s])for(t in i)n=i[t],e[t]==r&&(e[t]=n);return e}function a(e,t)
-{var n,r;if(e)for(n in t=p(t),e)if(it.call(e,n)&&(r=e[n],t(r,n,e)===J))break}function f(e,t){var n,r;if(e)for(n in t=p(t),e)if(r=e[n],t(r,n,e)===J)break}function l(e){if(e&&e.__wrapped__)return e;if(!(this instanceof l))return new l(e);this.__wrapped__=e}function c(e,n){var r=e.b,i=n.b,e=e.a,n=n.a;if(e!==n){if(e>n||e===t)return 1;if(e<n||n===t)return-1}return r<i?-1:1}function h(e,t,n){function r(){var i=arguments,s=t;return n.length&&(i=i.length?n.concat(ot.call(i)):n),this instanceof r?(m.prototype=
+;(function(e,t){function s(e,t,n){var r;if(!e)return e;var t=p(t,n),i=e.length,n=-1;if("number"==typeof i){for(;++n<i;)if(r=e[n],t(r,n,e)===J)return e}else for(n in e)if(it.call(e,n)&&(r=e[n],t(r,n,e)===J))return e}function o(e){var t,n,r=e;if(!e)return e;for(var i=1,s=arguments.length;i<s;i++)if(r=arguments[i])for(t in r)n=r[t],e[t]=n;return e}function u(e){var t,n,i=e;if(!e)return e;for(var s=1,o=arguments.length;s<o;s++)if(i=arguments[s])for(t in i)n=i[t],e[t]==r&&(e[t]=n);return e}function a(e
+,t){var n,r;if(e)for(n in t=p(t),e)if(it.call(e,n)&&(r=e[n],t(r,n,e)===J))break}function f(e,t){var n,r;if(e)for(n in t=p(t),e)if(r=e[n],t(r,n,e)===J)break}function l(e){if(e&&e.__wrapped__)return e;if(!(this instanceof l))return new l(e);this.__wrapped__=e}function c(e,n){var r=e.b,i=n.b,e=e.a,n=n.a;if(e!==n){if(e>n||e===t)return 1;if(e<n||n===t)return-1}return r<i?-1:1}function h(e,t,n){function r(){var i=arguments,s=t;return n.length&&(i=i.length?n.concat(ot.call(i)):n),this instanceof r?(m.prototype=
 e.prototype,s=new m,(i=e.apply(s,i))&&Tt[typeof i]?i:s):e.apply(s,i)}return r}function p(e,n){return e?"function"!=typeof e?function(t){return t[e]}:n!==t?function(t,r,i){return e.call(n,t,r,i)}:e:U}function d(e){return"\\"+Nt[e]}function v(e){return Ct[e]}function m(){}function g(e){return kt[e]}function y(e){var t=[];return a(e,function(e,n){t.push(n)}),t}function b(e){var t=[];return f(e,function(e,n){S(e)&&t.push(n)}),t.sort()}function w(e){var t={};return a(e,function(e,n){t[e]=n}),t}function E
 (e,t,s,o){if(e===t)return 0!==e||1/e==1/t;if(e==r||t==r)return e===t;var u=ut.call(e);if(u!=ut.call(t))return i;switch(u){case mt:case gt:return+e==+t;case yt:return e!=+e?t!=+t:0==e?1/e==1/t:e==+t;case wt:case Et:return e==t+""}var a=u==vt;if(!a){if(e.__wrapped__||t.__wrapped__)return E(e.__wrapped__||e,t.__wrapped__||t);if(u!=bt)return i;var u=e.constructor,f=t.constructor;if(u!=f&&(!S(u)||!(u instanceof u&&S(f)&&f instanceof f)))return i}s||(s=[]),o||(o=[]);for(u=s.length;u--;)if(s[u]==e)return o
 [u]==t;u=n,f=0,s.push(e),o.push(t);if(a){f=e.length;if(u=f==t.length)for(;f--&&(u=E(e[f],t[f],s,o)););return u}for(var l in e)if(it.call(e,l)&&(f++,!it.call(t,l)||!E(e[l],t[l],s,o)))return i;for(l in t)if(it.call(t,l)&&!(f--))return i;return n}function S(e){return"function"==typeof e}function x(e){return ut.call(e)==Et}function T(e){var t=[];return a(e,function(e){t.push(e)}),t}function N(e,t){return"number"==typeof (e?e.length:0)?-1<j(e,t):P(e,function(e){return e===t})}function C(e,t,r){var i=n
diff --git a/test/test-build.js b/test/test-build.js
index 89548e397..836774f3a 100644
--- a/test/test-build.js
+++ b/test/test-build.js
@@ -632,21 +632,23 @@
         vm.runInContext(source, context);
         var lodash = context._;
 
-        lodash.each(array, function(value) {
-          last = value;
-          return false;
-        });
-
-        var object = { 'fn': lodash.bind(function(x) { return this.x + x; }, { 'x': 1 }, 1) };
+        var object = { 'fn': lodash.bind(function(foo) { return foo + this.bar; }, { 'bar': 1 }, 1) };
         equal(object.fn(), 2, '_.bind: ' + basename);
 
-        ok(lodash.clone(array, true)[0] === array[0], '_.clone: ' + basename);
-        equal(last.value, 2, '_.each: ' + basename);
+        ok(lodash.clone(array, true)[0] === array[0], '_.clone should be shallow: ' + basename);
         equal(lodash.every([true, false, true]), false, '_.every: ' + basename);
 
         object = { 'length': 0, 'splice': Array.prototype.splice };
         equal(lodash.isEmpty(object), false, '_.isEmpty: ' + basename);
 
+        var actual = lodash.forEach(array, function(value) {
+          last = value;
+          return false;
+        });
+
+        equal(last.value, 2, '_.forEach should not exit early: ' + basename);
+        equal(actual, undefined, '_.forEach should return undefined: ' + basename);
+
         // avoid issues comparing objects with `deepEqual`
         object = { 'a': 1, 'b': 2, 'c': 3 };
         var actual = lodash.omit(object, function(value) { return value == 3; });