Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-11 03:17:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #435 -- allows _.max and _.min on arrays of dates without converting them to numbers.

Browse Source
This commit is contained in:
Jeremy Ashkenas
2012-01-24 10:40:20 -05:00
parent 908c015631
commit 3512e7fc5c
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/collections.js
View File

@@ -185,7 +185,9 @@ $(document).ready(function() {
// Relevant when using ClojureScript // Relevant when using ClojureScript
test('collections: invoke when strings have a call method', function() { test('collections: invoke when strings have a call method', function() {
String.prototype.call = function(){return 42;} String.prototype.call = function() {
return 42;
};
var list = [[5, 1, 7], [3, 2, 1]]; var list = [[5, 1, 7], [3, 2, 1]];
var s = "foo"; var s = "foo";
equals(s.call(), 42, "call function exists"); equals(s.call(), 42, "call function exists");
@@ -219,6 +221,10 @@ $(document).ready(function() {
equals(Infinity, _.min({}), 'Minimum value of an empty object'); equals(Infinity, _.min({}), 'Minimum value of an empty object');
equals(Infinity, _.min([]), 'Minimum value of an empty array'); equals(Infinity, _.min([]), 'Minimum value of an empty array');
var now = new Date(9999999999);
var then = new Date(0);
equals(_.min([now, then]), then);
}); });
test('collections: sortBy', function() { test('collections: sortBy', function() {

4
underscore.js
View File

@@ -224,7 +224,7 @@
// Return the maximum element or (element-based computation). // Return the maximum element or (element-based computation).
_.max = function(obj, iterator, context) { _.max = function(obj, iterator, context) {
if (!iterator && _.isArray(obj)) return Math.max.apply(Math, obj); if (!iterator && _.isArray(obj) && obj[0] === +obj[0]) return Math.max.apply(Math, obj);
if (!iterator && _.isEmpty(obj)) return -Infinity; if (!iterator && _.isEmpty(obj)) return -Infinity;
var result = {computed : -Infinity}; var result = {computed : -Infinity};
each(obj, function(value, index, list) { each(obj, function(value, index, list) {
@@ -236,7 +236,7 @@
// Return the minimum element (or element-based computation). // Return the minimum element (or element-based computation).
_.min = function(obj, iterator, context) { _.min = function(obj, iterator, context) {
if (!iterator && _.isArray(obj)) return Math.min.apply(Math, obj); if (!iterator && _.isArray(obj) && obj[0] === +obj[0]) return Math.min.apply(Math, obj);
if (!iterator && _.isEmpty(obj)) return Infinity; if (!iterator && _.isEmpty(obj)) return Infinity;
var result = {computed : Infinity}; var result = {computed : Infinity};
each(obj, function(value, index, list) { each(obj, function(value, index, list) {