Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-05 01:17:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure _.padLeft and _.padRight handle empty strings correctly.

Browse Source
This commit is contained in:
jdalton
2015-04-30 09:06:48 -07:00
parent 6cab7ceb0f
commit 2ce9e09e8b
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lodash.src.js
View File

@@ -3638,7 +3638,7 @@
function createPadDir(fromRight) { function createPadDir(fromRight) {
return function(string, length, chars) { return function(string, length, chars) {
string = baseToString(string); string = baseToString(string);
return string && ((fromRight ? string : '') + createPadding(string, length, chars) + (fromRight ? '' : string)); return (fromRight ? string : '') + createPadding(string, length, chars) + (fromRight ? '' : string);
}; };
} }

10
test/test.js
View File

@@ -11474,6 +11474,7 @@
_.each(['pad', 'padLeft', 'padRight'], function(methodName) { _.each(['pad', 'padLeft', 'padRight'], function(methodName) {
var func = _[methodName], var func = _[methodName],
isPad = methodName == 'pad',
isPadLeft = methodName == 'padLeft'; isPadLeft = methodName == 'padLeft';
test('`_.' + methodName + '` should not pad is string is >= `length`', 2, function() { test('`_.' + methodName + '` should not pad is string is >= `length`', 2, function() {
@@ -11494,11 +11495,12 @@
}); });
}); });
test('`_.' + methodName + '` should return an empty string when provided nullish or empty string values and `chars`', 6, function() { test('`_.' + methodName + '` should treat nullish values as empty strings', 6, function() {
_.each([null, '_-'], function(chars) { _.each([null, '_-'], function(chars) {
strictEqual(func(null, 0, chars), ''); var expected = chars ? (isPad ? '__' : chars) : ' ';
strictEqual(func(undefined, 0, chars), ''); strictEqual(func(null, 2, chars), expected);
strictEqual(func('', 0, chars), ''); strictEqual(func(undefined, 2, chars), expected);
strictEqual(func('', 2, chars), expected);
}); });
}); });