From 2b1bda7418994ac3853e9290646a269817d0ba48 Mon Sep 17 00:00:00 2001 From: John-David Dalton Date: Sat, 13 Aug 2016 13:50:21 -0700 Subject: [PATCH] Remove old Chrome and Firefox fixes. --- lodash.js | 8 +------- test/test.js | 18 +++--------------- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/lodash.js b/lodash.js index 4ee517c90..4d8edbb76 100644 --- a/lodash.js +++ b/lodash.js @@ -164,9 +164,6 @@ /** Used to match `RegExp` flags from their coerced string values. */ var reFlags = /\w*$/; - /** Used to detect hexadecimal string values. */ - var reHasHexPrefix = /^0x/i; - /** Used to detect bad signed hexadecimal string values. */ var reIsBadHex = /^[-+]0x[0-9a-f]+$/i; @@ -14071,15 +14068,12 @@ * // => [6, 8, 10] */ function parseInt(string, radix, guard) { - // Chrome fails to trim leading whitespace characters. - // See https://bugs.chromium.org/p/v8/issues/detail?id=3109 for more details. if (guard || radix == null) { radix = 0; } else if (radix) { radix = +radix; } - string = toString(string).replace(reTrim, ''); - return nativeParseInt(string, radix || (reHasHexPrefix.test(string) ? 16 : 10)); + return nativeParseInt(toString(string), radix || 0); } /** diff --git a/test/test.js b/test/test.js index 4ab0c7245..e96b328bb 100644 --- a/test/test.js +++ b/test/test.js @@ -11135,12 +11135,6 @@ skipAssert(assert); } }); - - QUnit.test('should avoid `[xpconnect wrapped native prototype]` in Firefox', function(assert) { - assert.expect(1); - - assert.strictEqual(_.isNumber(+'2'), true); - }); }(1, 2, 3)); /*--------------------------------------------------------------------------*/ @@ -16986,7 +16980,7 @@ assert.strictEqual(_.parseInt('08', 10), 8); }); - QUnit.test('should parse strings with leading whitespace (test in Chrome and Firefox)', function(assert) { + QUnit.test('should parse strings with leading whitespace', function(assert) { assert.expect(2); var expected = [8, 8, 10, 10, 32, 32, 32, 32]; @@ -20633,14 +20627,8 @@ ? 0 : Math.min(length, MAX_ARRAY_INDEX); - // Avoid false fails in older Firefox. - if (array.length == length) { - assert.ok(steps == 32 || steps == 33); - assert.strictEqual(actual, expected); - } - else { - skipAssert(assert, 2); - } + assert.ok(steps == 32 || steps == 33); + assert.strictEqual(actual, expected); }); }); });