Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-12 20:07:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure _.max and _.min return the correct value when callback computes +/-Infinity.

Browse Source
This commit is contained in:
John-David Dalton
2014-04-25 07:21:10 -07:00
parent 4c63be066f
commit 250ca36f05
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lodash.js
View File

@@ -4239,7 +4239,7 @@
baseEach(collection, function(value, index, collection) { baseEach(collection, function(value, index, collection) {
var current = callback(value, index, collection); var current = callback(value, index, collection);
if (current > computed) { if (current > computed || (current === -Infinity && current === result)) {
computed = current; computed = current;
result = value; result = value;
} }
@@ -4314,7 +4314,7 @@
baseEach(collection, function(value, index, collection) { baseEach(collection, function(value, index, collection) {
var current = callback(value, index, collection); var current = callback(value, index, collection);
if (current < computed) { if (current < computed || (current === Infinity && current === result)) {
computed = current; computed = current;
result = value; result = value;
} }

14
test/test.js
View File

@@ -2576,7 +2576,7 @@
}); });
test('should return `' + expected[1] + '` if value is not found', 1, function() { test('should return `' + expected[1] + '` if value is not found', 1, function() {
strictEqual(func(objects, function(object) { return object.a == 3; }), expected[1]); strictEqual(func(objects, function(object) { return object.a === 3; }), expected[1]);
}); });
test('should work with an object for `callback`', 1, function() { test('should work with an object for `callback`', 1, function() {
@@ -6297,7 +6297,17 @@
}); });
}); });
test('`_.' + methodName + '` should resolve the correct value when provided an array containing only one value', 1, function() { test('`_.' + methodName + '` should work when `callback` returns +/-Infinity', 1, function() {
var object = { 'a': (isMax ? -Infinity : Infinity) };
var actual = func([object, { 'a': object.a }], function(object) {
return object.a;
});
strictEqual(actual, object);
});
test('`_.' + methodName + '` should work when chaining on an array with only one value', 1, function() {
if (!isNpm) { if (!isNpm) {
var actual = _([40])[methodName]().value(); var actual = _([40])[methodName]().value();
strictEqual(actual, 40); strictEqual(actual, 40);