Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-11 19:37:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #524 from octatone/isFinite

Browse Source 
New Feature: _.isFinite to compliment _.isNumber and _.isNaN
This commit is contained in:
Jeremy Ashkenas
2012-04-02 12:07:28 -07:00
parent 719cd24aa9 ee86820473
commit 18ba865009
2 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/objects.js
View File

@@ -491,6 +491,20 @@ $(document).ready(function() {
ok(_.isRegExp(iRegExp), 'even from another frame'); ok(_.isRegExp(iRegExp), 'even from another frame');
}); });
test("objects: isFinite", function() {
ok(!_.isFinite(undefined), 'undefined is not Finite');
ok(!_.isFinite(null), 'null is not Finite');
ok(!_.isFinite(NaN), 'NaN is not Finite');
ok(!_.isFinite(Infinity), 'Infinity is not Finite');
ok(!_.isFinite(-Infinity), '-Infinity is not Finite');
ok(!_.isFinite('12'), 'Strings are not numbers');
var obj = new Number(5);
ok(_.isFinite(obj), 'Number instances can be finite');
ok(_.isFinite(0), '0 is Finite');
ok(_.isFinite(123), 'Ints are Finite');
ok(_.isFinite(-12.44), 'Floats are Finite');
});
test("objects: isNaN", function() { test("objects: isNaN", function() {
ok(!_.isNaN(undefined), 'undefined is not NaN'); ok(!_.isNaN(undefined), 'undefined is not NaN');
ok(!_.isNaN(null), 'null is not NaN'); ok(!_.isNaN(null), 'null is not NaN');

5
underscore.js
View File

@@ -824,6 +824,11 @@
return toString.call(obj) == '[object Number]'; return toString.call(obj) == '[object Number]';
}; };
// Is a givin number finite?
_.isFinite = function(obj) {
return _.isNumber(obj) && isFinite(obj);
};
// Is the given value `NaN`? // Is the given value `NaN`?
_.isNaN = function(obj) { _.isNaN = function(obj) {
// `NaN` is the only value for which `===` is not reflexive. // `NaN` is the only value for which `===` is not reflexive.