Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-10 19:07:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure _.slice handles a limit of 0 in Node 0.10.

Browse Source
This commit is contained in:
John-David Dalton
2016-04-09 00:53:07 -07:00
parent 74f6af8686
commit 17e1a6dbe8
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lodash.js
View File

@@ -13553,18 +13553,21 @@
* // => ['a', 'b'] * // => ['a', 'b']
*/ */
function split(string, separator, limit) { function split(string, separator, limit) {
string = toString(string);
if (limit && typeof limit != 'number' && isIterateeCall(string, separator, limit)) { if (limit && typeof limit != 'number' && isIterateeCall(string, separator, limit)) {
separator = limit = undefined; separator = limit = undefined;
} }
limit = limit === undefined ? MAX_ARRAY_LENGTH : limit >>> 0;
if (!limit) {
return [];
}
string = toString(string);
if (string && ( if (string && (
typeof separator == 'string' || typeof separator == 'string' ||
(separator != null && !isRegExp(separator)) (separator != null && !isRegExp(separator))
)) { )) {
separator += ''; separator += '';
if (separator == '' && reHasComplexSymbol.test(string)) { if (separator == '' && reHasComplexSymbol.test(string)) {
var strSymbols = stringToArray(string); return baseCastArray(stringToArray(string), 0, limit);
return limit === undefined ? strSymbols : strSymbols.slice(0, limit >>> 0);
} }
} }
return string.split(separator, limit); return string.split(separator, limit);

2
test/test.js
View File

@@ -23286,7 +23286,7 @@
assert.deepEqual(_.split(string, ' ', 3), ['A', leafs + ',', comboGlyph + ',']); assert.deepEqual(_.split(string, ' ', 3), ['A', leafs + ',', comboGlyph + ',']);
assert.deepEqual(_.split(string, undefined), [string]); assert.deepEqual(_.split(string, undefined), [string]);
assert.deepEqual(_.split(string, undefined, -1), [string]); assert.deepEqual(_.split(string, undefined, -1), [string]);
assert.deepEqual(_.split(string, undefined, 0), string.split(undefined, 0)); assert.deepEqual(_.split(string, undefined, 0), []);
var expected = ['A', ' ', leafs, ',', ' ', comboGlyph, ',', ' ', 'a', 'n', 'd', ' ', rocket]; var expected = ['A', ' ', leafs, ',', ' ', comboGlyph, ',', ' ', 'a', 'n', 'd', ' ', rocket];