Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-09 18:37:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove non-enumerable prototype property tests.

Browse Source
This commit is contained in:
John-David Dalton
2015-07-19 12:15:11 -07:00
parent 51425788d8
commit 15b1a22501
1 changed files with 11 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
test/test.js
View File

@@ -4964,6 +4964,17 @@
skipTest(); skipTest();
} }
}); });
test('`_.' + methodName + '` fixes the JScript `[[DontEnum]]` bug (test in IE < 9)', 1, function() {
if (func) {
var props = [];
func(shadowObject, function(value, prop) { props.push(prop); });
deepEqual(props.sort(), shadowProps);
}
else {
skipTest();
}
});
}); });
_.each(collectionMethods, function(methodName) { _.each(collectionMethods, function(methodName) {
@@ -5051,36 +5062,6 @@
/*--------------------------------------------------------------------------*/ /*--------------------------------------------------------------------------*/
QUnit.module('collection iteration bugs');
_.each(['forEach', 'forEachRight', 'forIn', 'forInRight', 'forOwn', 'forOwnRight'], function(methodName) {
var func = _[methodName];
test('`_.' + methodName + '` fixes the JScript `[[DontEnum]]` bug (test in IE < 9)', 1, function() {
var props = [];
func(shadowObject, function(value, prop) { props.push(prop); });
deepEqual(props.sort(), shadowProps);
});
test('`_.' + methodName + '` skips the prototype property of functions (test in Firefox < 3.6, Opera > 9.50 - Opera < 11.60, and Safari < 5.1)', 2, function() {
function Foo() {}
Foo.prototype.a = 1;
var props = [];
function callback(value, prop) { props.push(prop); }
func(Foo, callback);
deepEqual(props, []);
props.length = 0;
Foo.prototype = { 'a': 1 };
func(Foo, callback);
deepEqual(props, []);
});
});
/*--------------------------------------------------------------------------*/
QUnit.module('object assignments'); QUnit.module('object assignments');
_.each(['assign', 'defaults', 'extend', 'merge'], function(methodName) { _.each(['assign', 'defaults', 'extend', 'merge'], function(methodName) {
@@ -5128,18 +5109,6 @@
deepEqual(func(object, source), shadowObject); deepEqual(func(object, source), shadowObject);
}); });
test('`_.' + methodName + '` skips the prototype property of functions (test in Firefox < 3.6, Opera > 9.50 - Opera < 11.60, and Safari < 5.1)', 2, function() {
function Foo() {}
Foo.a = 1;
Foo.prototype.b = 2;
var expected = { 'a': 1 };
deepEqual(func({}, Foo), expected);
Foo.prototype = { 'b': 2 };
deepEqual(func({}, Foo), expected);
});
test('`_.' + methodName + '` should not error on nullish sources', 1, function() { test('`_.' + methodName + '` should not error on nullish sources', 1, function() {
try { try {
deepEqual(func({ 'a': 1 }, undefined, { 'b': 2 }, null), { 'a': 1, 'b': 2 }); deepEqual(func({ 'a': 1 }, undefined, { 'b': 2 }, null), { 'a': 1, 'b': 2 });
@@ -6558,16 +6527,6 @@
strictEqual(_.isEmpty(shadowObject), false); strictEqual(_.isEmpty(shadowObject), false);
}); });
test('should skip the prototype property of functions (test in Firefox < 3.6, Opera > 9.50 - Opera < 11.60, and Safari < 5.1)', 2, function() {
function Foo() {}
Foo.prototype.a = 1;
strictEqual(_.isEmpty(Foo), true);
Foo.prototype = { 'a': 1 };
strictEqual(_.isEmpty(Foo), true);
});
test('should return an unwrapped value when implicitly chaining', 1, function() { test('should return an unwrapped value when implicitly chaining', 1, function() {
if (!isNpm) { if (!isNpm) {
strictEqual(_({}).isEmpty(), true); strictEqual(_({}).isEmpty(), true);
@@ -8944,18 +8903,6 @@
}); });
}); });
test('`_.' + methodName + '` skips the prototype property of functions (test in Firefox < 3.6, Opera > 9.50 - Opera < 11.60, and Safari < 5.1)', 2, function() {
function Foo() {}
Foo.a = 1;
Foo.prototype.b = 2;
var expected = ['a'];
deepEqual(func(Foo), expected);
Foo.prototype = { 'b': 2 };
deepEqual(func(Foo), expected);
});
test('`_.' + methodName + '` skips the `constructor` property on prototype objects', 3, function() { test('`_.' + methodName + '` skips the `constructor` property on prototype objects', 3, function() {
function Foo() {} function Foo() {}
Foo.prototype.a = 1; Foo.prototype.a = 1;