From 13d62b01d1693fcdeba33c5b775ce6a4b6245d40 Mon Sep 17 00:00:00 2001 From: John-David Dalton Date: Sun, 9 Dec 2012 23:25:59 -0800 Subject: [PATCH] Ensure utf-8 encoding and tweak text in CONTRIBUTING.md. Former-commit-id: 67a3e585c0a3b815e916e0d38ed2bc113de3220d --- CONTRIBUTING.md | 27 ++++--- vendor/firebug-lite/skin/xp/firebug-1.3a2.css | 28 +++---- vendor/firebug-lite/skin/xp/firebug.css | 68 ++++++++-------- vendor/firebug-lite/skin/xp/firebug.html | 80 +++++++++---------- 4 files changed, 104 insertions(+), 99 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 19c542ac0..db21069c0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,30 +1,35 @@ # Contributing to Lo-Dash -If youÕd like to contribute a feature or bug fix, you can [fork](https://help.github.com/articles/fork-a-repo) Lo-Dash, commit your changes, and [send a pull request](https://help.github.com/articles/using-pull-requests). +If you’d like to contribute a feature or bug fix, you can [fork](https://help.github.com/articles/fork-a-repo) Lo-Dash, commit your changes, and [send a pull request](https://help.github.com/articles/using-pull-requests). Please make sure to [search the issue tracker](https://github.com/bestiejs/lodash/issues) first; your issue may have already been discussed or fixed in `master`. ## Tests -Please make sure to update the unit tests in the `test` directory as part of your pull request. +Include updated unit tests in the `test` directory as part of your pull request. You can run the tests from the command line via `npm test`, or open `test/index.html` in a web browser. -The `test/run-test.sh` script attempts to run the tests in [Rhino](http://www.mozilla.org/rhino/), [RingoJS](http://ringojs.org/), [Narwhal](https://github.com/280north/narwhal), and [Node](http://nodejs.org/), before starting your default browser. +The `test/run-test.sh` script attempts to run the tests in [Rhino](http://www.mozilla.org/rhino/), [RingoJS](http://ringojs.org/), [Narwhal](https://github.com/280north/narwhal), and [Node](http://nodejs.org/), before running them in your default browser. The [Backbone](http://backbonejs.org/) and [Underscore](http://http://underscorejs.org/) test suites are included as well. -We also use [Travis CI](https://travis-ci.org/bestiejs/lodash) for continuous integration. - ## Contributor License Agreement Lo-Dash is a [Dojo Foundation](http://dojofoundation.org/) project. As such, we request that all contributors sign the Dojo Foundation [contributor license agreement](http://dojofoundation.org/about/claForm). -You can also [check](http://dojofoundation.org/about/claCheck) if youÕve already signed a CLA. -For more information about CLAs, please check out Alex RussellÕs excellent post, ["Why Do I Need to Sign This?"](http://infrequently.org/2008/06/why-do-i-need-to-sign-this/). +For more information about CLAs, please check out Alex Russell’s excellent post, ["Why Do I Need to Sign This?"](http://infrequently.org/2008/06/why-do-i-need-to-sign-this/). ## Coding Guidelines In addition to the following guidelines, please follow the conventions already established in the code. -- **Spacing**: Use two spaces for indentation. No tabs. -- **Naming**: Keep variable and method names concise and descriptive. Variable names `index`, `collection`, and `callback` are preferable to `i`, `arr`, and `fn`. -- **Quotes**: Single-quoted strings are preferred to double-quoted strings; however, please use a double-quoted string if the value contains a single-quote character to avoid unnecessary escaping. -- **Comments**: Please use single-line comments to annotate significant additions, and [JSDoc-style](http://www.2ality.com/2011/08/jsdoc-intro.html) comments for new methods. We use [Docdown](https://github.com/jdalton/docdown) to generate our documentation. +- **Spacing**:
+ Use two spaces for indentation. No tabs. + +- **Naming**:
+ Keep variable and method names concise and descriptive.
+ Variable names `index`, `collection`, and `callback` are preferable to `i`, `arr`, and `fn`. + +- **Quotes**:
+ Single-quoted strings are preferred to double-quoted strings; however, please use a double-quoted string if the value contains a single-quote character to avoid unnecessary escaping. + +- **Comments**:
+ Please use single-line comments to annotate significant additions, and [JSDoc-style](http://www.2ality.com/2011/08/jsdoc-intro.html) comments for new methods. diff --git a/vendor/firebug-lite/skin/xp/firebug-1.3a2.css b/vendor/firebug-lite/skin/xp/firebug-1.3a2.css index 42f9faf5d..d929b2bf1 100644 --- a/vendor/firebug-lite/skin/xp/firebug-1.3a2.css +++ b/vendor/firebug-lite/skin/xp/firebug-1.3a2.css @@ -70,7 +70,7 @@ html, body { body { font-family: Lucida Grande, Tahoma, sans-serif; font-size: 11px; - background: #fff; + background: #fff; } .clear { @@ -103,7 +103,7 @@ body { border: 1px solid #ccc; margin: 0 5px 0 0; background: #fff url(search.png) no-repeat 4px 2px; - padding-left: 20px; + padding-left: 20px; font-size: 11px; } @@ -124,7 +124,7 @@ body { height: 14px; background: url(errorIcon.png) no-repeat; color: #f00; - font-weight: bold; + font-weight: bold; } #fbMiniErrors { @@ -139,7 +139,7 @@ body { margin: 3px 4px 0; height: 20px; width: 20px; - float: right; + float: right; background: url(sprite.png) 0 -135px; cursor: pointer; } @@ -192,10 +192,10 @@ body { } /************************************************************************************************ - Sub-Layout + Sub-Layout *************************************************************************************************/ -/* fbToolbar +/* fbToolbar *************************************************************************************************/ #fbToolbarIcon { float: left; @@ -237,7 +237,7 @@ body { position: relative; top: 5px; line-height: 19px; - cursor: default; + cursor: default; } .fbToolbarSeparator{ @@ -262,7 +262,7 @@ body { .fbStatusBar span a:hover { color: blue; - cursor: pointer; + cursor: pointer; } @@ -307,7 +307,7 @@ body { padding-left: 10px; } -/* body +/* body *************************************************************************************************/ .fbPanel { display: none; @@ -340,7 +340,7 @@ body { visibility: hidden !important; } -/* fbBottom +/* fbBottom *************************************************************************************************/ #fbCommand { @@ -391,7 +391,7 @@ div.fbFitHeight { Layout Controls *************************************************************************************************/ -/* fbToolbar buttons +/* fbToolbar buttons *************************************************************************************************/ #fbWindowButtons a { font-size: 1px; @@ -420,7 +420,7 @@ div.fbFitHeight { background: url(sprite.png) -48px -119px; } -/* fbPanelBarBox tabs +/* fbPanelBarBox tabs *************************************************************************************************/ .fbTab { text-decoration: none; @@ -475,7 +475,7 @@ a.fbTab:hover .fbTabR { background: url(sprite.png) -8px -96px !important; } -/* splitters +/* splitters *************************************************************************************************/ #fbHSplitter { position: absolute; @@ -571,7 +571,7 @@ div.objectBox-element { color: #fff !important; } -/* Webkit CSS Hack - bug in "highlight" named color */ +/* Webkit CSS Hack - bug in "highlight" named color */ @media screen and (-webkit-min-device-pixel-ratio:0) { .selectedElement{ background: #316AC5; diff --git a/vendor/firebug-lite/skin/xp/firebug.css b/vendor/firebug-lite/skin/xp/firebug.css index a1465ec5f..f3bdd8cde 100644 --- a/vendor/firebug-lite/skin/xp/firebug.css +++ b/vendor/firebug-lite/skin/xp/firebug.css @@ -136,10 +136,10 @@ h1.groupHeader { position: relative; top: -7px; left: -5px; - + outline: none; resize: none; - + /* _border: 1px solid #999 !important; _padding: 1px !important; @@ -311,17 +311,17 @@ h1.groupHeader { outline: none; background-color: transparent } - - .useA11y .a11yCSSView .focusRow:focus .cssSelector, - .useA11y .a11yCSSView .focusRow:focus .cssPropName, + + .useA11y .a11yCSSView .focusRow:focus .cssSelector, + .useA11y .a11yCSSView .focusRow:focus .cssPropName, .useA11y .a11yCSSView .focusRow:focus .cssPropValue, - .useA11y .a11yCSSView .computedStyleRow:focus, + .useA11y .a11yCSSView .computedStyleRow:focus, .useA11y .a11yCSSView .groupHeader:focus { outline: 2px solid #FF9933; outline-offset: -2px; background-color: #FFFFD6; } - + .useA11y .a11yCSSView .groupHeader:focus { outline-offset: -2px; } @@ -731,7 +731,7 @@ h1.groupHeader { /* Time Info tip */ .timeInfoTip { - width: 150px; + width: 150px; height: 40px } @@ -944,7 +944,7 @@ h1.groupHeader { /*overflow-x: auto; HTML is damaged in case of big (2-3MB) responses */ } -/* replaced by .netInfoTextSelected for IE6 support +/* replaced by .netInfoTextSelected for IE6 support .netInfoText[selected="true"] { display: block; } @@ -963,7 +963,7 @@ h1.groupHeader { } .netInfoPostText .netInfoParamName { - width: 1px; /* Google Chrome need this otherwise the first column of + width: 1px; /* Google Chrome need this otherwise the first column of the post variables table will be larger than expected */ } @@ -1148,7 +1148,7 @@ h1.groupHeader { } * html .opened .spyHead .spyTitle, -* html .opened .logGroupLabel, +* html .opened .logGroupLabel, * html .opened .memberLabelCell .memberLabel { background-image: url(tree_close.gif); background-repeat: no-repeat; @@ -1677,7 +1677,7 @@ h1.groupHeader { /* .logRow-errorMessage > .hasTwisty > .errorTitle, .logRow-spy .spyHead .spyTitle, -.logGroup > .logRow +.logGroup > .logRow */ .logRow-errorMessage .hasTwisty .errorTitle, .logRow-spy .spyHead .spyTitle, @@ -2056,11 +2056,11 @@ h1.groupHeader { width: 10px; height: 10px; margin-top: 6px; - background: url(tabMenuTarget.png); + background: url(tabMenuTarget.png); } .fbTabMenuTarget:hover { - background: url(tabMenuTargetHover.png); + background: url(tabMenuTargetHover.png); } .fbShadow { @@ -2098,7 +2098,7 @@ h1.groupHeader { padding: 1px 18px 0; text-decoration: none; color: #000; - cursor: default; + cursor: default; background: #ACA899; margin: 4px 0; } @@ -2149,7 +2149,7 @@ h1.groupHeader { } .fbMenuShortcut { - padding-right: 85px; + padding-right: 85px; } .fbMenuShortcutKey { @@ -2274,7 +2274,7 @@ h1.groupHeader { margin: 0; padding: 0; overflow: hidden; - + font-family: Lucida Grande, Tahoma, sans-serif; font-size: 11px; background: #fff; @@ -2311,7 +2311,7 @@ h1.groupHeader { margin: 0 5px 0 0; background: #fff url(search.png) no-repeat 4px 2px !important; background: #fff url(search.gif) no-repeat 4px 2px; - padding-left: 20px; + padding-left: 20px; font-size: 11px; } @@ -2333,7 +2333,7 @@ h1.groupHeader { background: url(errorIcon.png) no-repeat !important; background: url(errorIcon.gif) no-repeat; color: #f00; - font-weight: bold; + font-weight: bold; } #fbMiniErrors { @@ -2348,7 +2348,7 @@ h1.groupHeader { margin: 3px 4px 0; height: 20px; width: 20px; - float: right; + float: right; background: url(sprite.png) 0 -135px; cursor: pointer; } @@ -2403,10 +2403,10 @@ h1.groupHeader { } /************************************************************************************************ - Sub-Layout + Sub-Layout *************************************************************************************************/ -/* fbToolbar +/* fbToolbar *************************************************************************************************/ #fbToolbarIcon { float: left; @@ -2472,7 +2472,7 @@ h1.groupHeader { #fbStatusBarBox { top: 4px; - cursor: default; + cursor: default; } .fbToolbarSeparator { @@ -2500,7 +2500,7 @@ h1.groupHeader { .fbStatusBar a:hover { color: blue; - cursor: pointer; + cursor: pointer; } @@ -2545,7 +2545,7 @@ h1.groupHeader { padding-left: 4px; } -/* body +/* body *************************************************************************************************/ .fbPanel { display: none; @@ -2609,7 +2609,7 @@ h1.groupHeader { position: absolute; right: 2px; bottom: 3px; - + z-index: 99; } @@ -2624,7 +2624,7 @@ h1.groupHeader { visibility: hidden !important; } -/* fbBottom +/* fbBottom *************************************************************************************************/ #fbCommand { @@ -2689,7 +2689,7 @@ div.fbFitHeight { Layout Controls *************************************************************************************************/ -/* fbToolbar buttons +/* fbToolbar buttons *************************************************************************************************/ .fbSmallButton { overflow: hidden; @@ -2729,7 +2729,7 @@ div.fbFitHeight { } -/* fbPanelBarBox tabs +/* fbPanelBarBox tabs *************************************************************************************************/ .fbTab { text-decoration: none; @@ -2785,7 +2785,7 @@ a.fbTab:hover .fbTabR { background: url(sprite.png) -8px -96px !important; } -/* splitters +/* splitters *************************************************************************************************/ #fbHSplitter { position: fixed; @@ -2888,7 +2888,7 @@ div.objectBox-element { position: relative; } -/* Webkit CSS Hack - bug in "highlight" named color */ +/* Webkit CSS Hack - bug in "highlight" named color */ @media screen and (-webkit-min-device-pixel-ratio:0) { .selectedElement{ background: #316AC5; @@ -2903,7 +2903,7 @@ div.objectBox-element { } /* TODO: remove this? */ -/* TODO: xxxpedro - IE need this in windowless mode (cnn.com) check if the issue is related to +/* TODO: xxxpedro - IE need this in windowless mode (cnn.com) check if the issue is related to position. if so, override it at chrome.js initialization when creating the div */ .logRow { position: relative; @@ -2939,9 +2939,9 @@ position. if so, override it at chrome.js initialization when creating the div * .objectBox-string { color: red; - + /* TODO: xxxpedro make long strings break line */ - /*white-space: pre; */ + /*white-space: pre; */ } .objectBox-number { diff --git a/vendor/firebug-lite/skin/xp/firebug.html b/vendor/firebug-lite/skin/xp/firebug.html index aa078099f..c2b5c4347 100644 --- a/vendor/firebug-lite/skin/xp/firebug.html +++ b/vendor/firebug-lite/skin/xp/firebug.html @@ -14,71 +14,71 @@ - - - +
     
- +
- +   - - - + Inspect - + Clear - + - - + - - +
- +
- +
- + - +
 
- + - + - +
@@ -150,41 +150,41 @@
- + - +
 
- +
- +
- +
- + - +
Run Clear - +
- + - + - + - +
@@ -193,18 +193,18 @@
- + - + - + -