Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-08 18:17:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve #isEmpty implementation. add 2 tests

Browse Source
This commit is contained in:
Mike Frawley
2010-02-17 09:48:29 -06:00
parent 386ee8ade9
commit 130e860ecf
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/objects.js
View File

@@ -60,6 +60,8 @@ $(document).ready(function() {
ok(_.isEmpty([]), '[] is empty'); ok(_.isEmpty([]), '[] is empty');
ok(!_.isEmpty({one : 1}), '{one : 1} is not empty'); ok(!_.isEmpty({one : 1}), '{one : 1} is not empty');
ok(_.isEmpty({}), '{} is empty'); ok(_.isEmpty({}), '{} is empty');
ok(_.isEmpty(null), 'null is empty');
ok(_.isEmpty(), 'undefined is empty');
var obj = {one : 1}; var obj = {one : 1};
delete obj.one; delete obj.one;

4
underscore.js
View File

@@ -503,7 +503,9 @@
// Is a given array or object empty? // Is a given array or object empty?
_.isEmpty = function(obj) { _.isEmpty = function(obj) {
return _.keys(obj).length == 0; if (_.isArray(obj)) return obj.length===0;
for (var k in obj) return false;
return true;
}; };
// Is a given value a DOM element? // Is a given value a DOM element?