Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-11 03:17:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure _.isElement uses strict equality in its duck type check.

Browse Source 
Former-commit-id: 6348026ebdc219ef1df9926aca1d8df66e472de9
This commit is contained in:
John-David Dalton
2012-08-18 21:41:29 -07:00
parent 285f0bc6dd
commit 0c25dd44b3
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lodash.js
View File

@@ -1281,7 +1281,7 @@
* // => true * // => true
*/ */
function isElement(value) { function isElement(value) {
return value ? value.nodeType == 1 : false; return value ? value.nodeType === 1 : false;
} }
/** /**

17
test/test.js
View File

@@ -699,6 +699,23 @@
/*--------------------------------------------------------------------------*/ /*--------------------------------------------------------------------------*/
QUnit.module('lodash.isElement');
(function() {
test('should use strict equality in its duck type check', function() {
var element = window.document ? document.body : { 'nodeType': 1 };
equal(_.isElement(element), true);
equal(_.isElement({ 'nodeType': new Number(1) }), false);
equal(_.isElement({ 'nodeType': true }), false);
equal(_.isElement({ 'nodeType': [1] }), false);
equal(_.isElement({ 'nodeType': '1' }), false);
equal(_.isElement({ 'nodeType': '001' }), false);
});
}());
/*--------------------------------------------------------------------------*/
QUnit.module('lodash.isEmpty'); QUnit.module('lodash.isEmpty');
(function() { (function() {