Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-09 18:37:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove internal skipArgsCheck from _.isPlainObject and add unit tests.

Browse Source 
Former-commit-id: 213c1e95f61368eb8912850248a97f44664384d8
This commit is contained in:
John-David Dalton
2012-09-25 09:05:09 -07:00
parent 3beda8eea0
commit 04459eaa50
4 changed files with 128 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lodash.js
View File

@@ -926,8 +926,6 @@
* @memberOf _
* @category Objects
* @param {Mixed} value The value to check.
* @param- {Boolean} [skipArgsCheck=false] Internally used to skip checks for
* `arguments` objects.
* @returns {Boolean} Returns `true` if `value` is a plain object, else `false`.
* @example
*
@@ -945,7 +943,7 @@
* _.isPlainObject({ 'name': 'moe', 'age': 40 });
* // => true
*/
var isPlainObject = objectTypes.__proto__ != ObjectProto ? isPlainFallback : function(value, skipArgsCheck) {
var isPlainObject = objectTypes.__proto__ != ObjectProto ? isPlainFallback : function(value) {
if (!value) {
return false;
}
@@ -953,7 +951,7 @@
objProto = typeof valueOf == 'function' && (objProto = valueOf.__proto__) && objProto.__proto__;
return objProto
? value == objProto || (value.__proto__ == objProto && (skipArgsCheck || !isArguments(value)))
? value == objProto || (value.__proto__ == objProto && !isArguments(value))
: isPlainFallback(value);
};
@@ -965,14 +963,12 @@
*
* @private
* @param {Mixed} value The value to check.
* @param- {Boolean} [skipArgsCheck=false] Internally used to skip checks for
* `arguments` objects.
* @returns {Boolean} Returns `true` if `value` is a plain object, else `false`.
*/
function isPlainFallback(value, skipArgsCheck) {
function isPlainFallback(value) {
// avoid non-objects and false positives for `arguments` objects
var result = false;
if (!(value && typeof value == 'object') || (!skipArgsCheck && isArguments(value))) {
if (!(value && typeof value == 'object') || isArguments(value)) {
return result;
}
// IE < 9 presents DOM nodes as `Object` objects except they have `toString`
@@ -1070,7 +1066,7 @@
return value;
}
var isArr = className == arrayClass;
isObj = isArr || (className == objectClass ? isPlainObject(value, true) : isObj);
isObj = isArr || (className == objectClass ? isPlainObject(value) : isObj);
}
// shallow clone
if (!isObj || !deep) {