Mirrors/lodash
1
0
Fork 0
mirror of https://github.com/whoisclebs/lodash.git synced 2026-02-09 18:37:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure _.clone and _.cloneDeep work on prototype objects.

Browse Source
This commit is contained in:
John-David Dalton
2016-01-28 00:45:42 -08:00
parent 7bf7ab954b
commit 03f7205e6d
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lodash.js
View File

@@ -4956,6 +4956,9 @@
* @returns {Object} Returns the initialized clone. * @returns {Object} Returns the initialized clone.
*/ */
function initCloneObject(object) { function initCloneObject(object) {
if (isPrototype(object)) {
return {};
}
var Ctor = object.constructor; var Ctor = object.constructor;
return baseCreate(isFunction(Ctor) ? Ctor.prototype : undefined); return baseCreate(isFunction(Ctor) ? Ctor.prototype : undefined);
} }

11
test/test.js
View File

@@ -2520,13 +2520,22 @@
assert.strictEqual(actual.lastIndex, 3); assert.strictEqual(actual.lastIndex, 3);
}); });
QUnit.test('`_.' + methodName + '` should clone prototype objects', function(assert) {
assert.expect(2);
var actual = func(Foo.prototype);
assert.notOk(actual instanceof Foo);
assert.deepEqual(actual, { 'b': 1 });
});
QUnit.test('`_.' + methodName + '` should create clone with the same `[[Prototype]]` as `value`', function(assert) { QUnit.test('`_.' + methodName + '` should create clone with the same `[[Prototype]]` as `value`', function(assert) {
assert.expect(1); assert.expect(1);
assert.ok(func(new Foo) instanceof Foo); assert.ok(func(new Foo) instanceof Foo);
}); });
QUnit.test('should ensure `value` constructor is a function before using its `[[Prototype]]`', function(assert) { QUnit.test('`_.' + methodName + '` should ensure `value` constructor is a function before using its `[[Prototype]]`', function(assert) {
assert.expect(1); assert.expect(1);
Foo.prototype.constructor = null; Foo.prototype.constructor = null;